Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

Define the initial shipper gRPC interface #5

Closed
Tracked by #15
cmacknz opened this issue Mar 16, 2022 · 2 comments
Closed
Tracked by #15

Define the initial shipper gRPC interface #5

cmacknz opened this issue Mar 16, 2022 · 2 comments
Assignees
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team v8.3.0

Comments

@cmacknz
Copy link
Member

cmacknz commented Mar 16, 2022

Define the initial shipper gRPC service and use protoc to generate the client and server implementations. The interface should be defined in the https://github.com/elastic/elastic-agent-client repository to ensure the entire elastic agent interface is defined in one place, and can be imported without depending on it's internal implementation.

The proposal specifies an initial event protocol. Decide whether specification should be taken as the starting point, or we can start with a minimal version of it (a Publish RPC with empty request and response messages) and add to it as we add features tot he shipper.

The shipper gRPC client and server should be an importable Go package once this issue is complete.

@fearful-symmetry
Copy link
Contributor

With the first skeleton now merged, how much of this is still open? Do we want to move the gRPC code itself to the client repo?

@cmacknz
Copy link
Member Author

cmacknz commented Apr 1, 2022

Let's close this. I think our life may be easier with the proto files defined in the shipper repository as we iterate on them. We can move them later.

@cmacknz cmacknz closed this as completed Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team v8.3.0
Projects
None yet
Development

No branches or pull requests

3 participants