Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Partition] Link label text color parameter passed is ignored #1469

Closed
2 tasks done
dej611 opened this issue Nov 8, 2021 · 1 comment · Fixed by #1498
Closed
2 tasks done

[Partition] Link label text color parameter passed is ignored #1469

dej611 opened this issue Nov 8, 2021 · 1 comment · Fixed by #1498
Assignees
Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart :Lens Kibana Lens related issue :partition Partition/PieChart/Donut/Sunburst/Treemap chart related

Comments

@dej611
Copy link
Contributor

dej611 commented Nov 8, 2021

Describe the bug
While the textColor parameter is still accepted as valid for the linkLabel configuration object, its value is overwritten internally to the best "contrast" color against the container background color.

While the aim sounds nice, in Kibana charts embeddable cannot have a background color as Canvas requires them to be styleable somehow, so the background color is currently set to undefined/transparent. This leads to manually compute the textColor programmatically in Lens, and we land on the point above.

Expected behaviour
Respect the passed value for textColor.

Kibana Cross Issues
elastic/kibana#116777

Checklist

Delete any items that are not applicable to this issue.

  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@dej611 dej611 added bug Something isn't working kibana cross issue Has a Kibana issue counterpart :partition Partition/PieChart/Donut/Sunburst/Treemap chart related :Lens Kibana Lens related issue labels Nov 8, 2021
@nickofthyme
Copy link
Collaborator

I'll verify this is fixed in #1402.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart :Lens Kibana Lens related issue :partition Partition/PieChart/Donut/Sunburst/Treemap chart related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants