Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require settings locale property #2208

Open
drewdaemon opened this issue Oct 18, 2023 · 1 comment
Open

Require settings locale property #2208

drewdaemon opened this issue Oct 18, 2023 · 1 comment
Labels
:all Applies to all chart types enhancement New feature or request

Comments

@drewdaemon
Copy link
Contributor

drewdaemon commented Oct 18, 2023

With #2164 we got the ability to pass a locale to our charts. This was accomplished in Kibana with elastic/kibana#168571.

However, locale is currently an optional property. This increases the risk that it will be overlooked when new charts invocations are added to Kibana, resulting in subtle localization bugs.

We should consider requiring locale to make sure it is always provided.

@drewdaemon drewdaemon added enhancement New feature or request :all Applies to all chart types labels Oct 18, 2023
@nickofthyme
Copy link
Collaborator

nickofthyme commented Oct 18, 2023

Good point, it looks like the locale prop is optional on the Settings spec but even if it was required there'd be no way to require a Settings spec, although most charts in kibana use this.

I don't think there is a current solution to fix this given how elasstic charts is built but I think the work in #1424, to use a charts provider, would be useful for exactly these types of cases where we want global chart defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:all Applies to all chart types enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants