Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom curl configuration for entire client #382

Closed
polyfractal opened this issue Jan 25, 2016 · 2 comments
Closed

Allow custom curl configuration for entire client #382

polyfractal opened this issue Jan 25, 2016 · 2 comments

Comments

@polyfractal
Copy link
Contributor

Currently, you can configure custom curl options/headers on a per-request basis. It would be convenient if the same could be specified during client creation, and applied to all requests.

Related #376
@polyfractal polyfractal mentioned this issue Jan 25, 2016
Closed
@polyfractal polyfractal mentioned this issue May 17, 2016
Closed
@rayward
Copy link
Contributor

rayward commented Jul 13, 2016

Would be as simple as allowing the connection params to be configured in the ClientBuilder rather than having it hardcoded as an empty array: https://github.com/elastic/elasticsearch-php/blob/master/src/Elasticsearch/ClientBuilder.php#L428 ?

@Oliboy50
Copy link
Contributor

Oliboy50 commented Nov 29, 2016 •
edited
Loading

@rayward indeed
So, what is the main issue with that?

I'm working on a fix for this, i'll propose a PR as soon as I assert that it works

This was referenced Nov 29, 2016
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rayward @polyfractal @Oliboy50