Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESQL: early validation of the index name #112040

Closed
costin opened this issue Aug 20, 2024 · 1 comment · Fixed by #112081
Closed

ESQL: early validation of the index name #112040

costin opened this issue Aug 20, 2024 · 1 comment · Fixed by #112081
Assignees
@fang-xing-esql
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@costin
Copy link
Member

costin commented Aug 20, 2024

Description

At the moment, we don' perform any validation of the index name and instead rely on ES to do it for us. We should look into leveraging the existing validation code (that takes into account the restricted chars, date match, patterns, etc...) and see whether we could just reuse it to fail early queries that use an invalid index.
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Aug 20, 2024
@fang-xing-esql fang-xing-esql mentioned this issue Aug 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fang-xing-esql fang-xing-esql

Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ES|QL] Validate index name in parser fang-xing-esql/Elasticsearch
3 participants
@costin @elasticsearchmachine @fang-xing-esql