Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit deprecation warning on "enabled" attribute change #34219

Closed
cbuescher opened this issue Oct 2, 2018 · 2 comments
Closed

Emit deprecation warning on "enabled" attribute change #34219

cbuescher opened this issue Oct 2, 2018 · 2 comments
Labels
help wanted adoptme :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch

Comments

@cbuescher
Copy link
Member

Starting in 7.0, we will throw an error if a user tries to change the "enabled" attribut in a mapping (#33933 (edited).
In addition to this we should emit a deprecation warning in 6.x, letting the user know that their intended enabled setting mapping change is silently ignored
(see #33566) and that we will start throwing errors on this with the next major version.
@cbuescher cbuescher added help wanted adoptme :Search Foundations/Mapping Index mappings, including merging and defining field types v6.5.0 labels Oct 2, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@cbuescher
Copy link
Member Author

Closing since we decided to backport #33933 in the end.

@colings86 colings86 removed the v6.5.0 label Oct 25, 2018
@javanna javanna added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted adoptme :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@colings86 @javanna @cbuescher @elasticmachine