Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need restart tests #34524

Closed
nik9000 opened this issue Oct 16, 2018 · 3 comments
Closed

We need restart tests #34524

nik9000 opened this issue Oct 16, 2018 · 3 comments
Assignees
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests

Comments

@nik9000
Copy link
Member

nik9000 commented Oct 16, 2018

Right now we have "upgrade" tests but we don't have "restart" tests. It'd be good to have tests that assert that restarts work. Without them it is possible for us to break starting the current version of Elasticsearch with a data directory made by the current version of Elasticsearch. That sounds far fetched when I type it but we've made mistakes like that. We caught them we we backported the change and added upgrade tests.

I think the simplest way to accomplish this is to use the change the rolling upgrade tests and the full cluster restart tests to work when "upgrading" from the current version. That isn't perfect because you still have to know to write a restart/upgrade test for a change that might cause restarts to fail but lets solve one thing at a time.

@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests :Delivery/Build Build or test infrastructure labels Oct 16, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@alpar-t
Copy link
Contributor

alpar-t commented Oct 17, 2018

This will likely build on top of #34050.

@alpar-t
Copy link
Contributor

alpar-t commented Mar 7, 2019

This is now implemented in #39102

@alpar-t alpar-t closed this as completed Mar 7, 2019
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

No branches or pull requests

5 participants