Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport deprecation warning header limits to 5.6 #36243

Closed
orangejulius opened this issue Dec 5, 2018 · 2 comments
Closed

Backport deprecation warning header limits to 5.6 #36243

orangejulius opened this issue Dec 5, 2018 · 2 comments
Labels
:Core/Infra/Core Core issues without another label >enhancement v5.6.14

Comments

@orangejulius
Copy link
Contributor

orangejulius commented Dec 5, 2018

Hello!

In #28427, configuration options were added for the deprecation warning headers that are sent along in HTTP responses.

Please consider backporting these changes to Elasticsearch 5.6. In particular, because Node.js just released security updates that reject response headers over 8192 bytes, its likely a significant number of users of Node.js will now see issues due to those headers.

Hopefully, that will lead to them fixing the issues raised by the deprecation warnings! :)

However, in some cases, it's not feasible to fix the warnings immediately. In my case, I maintain an open source project (the Pelias geocoder), where we are currently migrating from Elasticsearch 2 to 5. We can't fix the deprecation warnings until we drop support for ES2, and we can't drop that support right away.

While there are discussions about setting a default to the number of warnings returned, even having the option to set that limit would be enough for now. I understand that setting new default config options might not be possible on older releases that are technically only getting bugfixes, and no behavior changes would be allowed.

Let me know if backporting this change is possible or if there is another solution. Thanks!

@cbuescher cbuescher added the :Core/Infra/Core Core issues without another label label Dec 5, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@jasontedor
Copy link
Member

Hi @orangejulius, thanks for your interest and raising this for discussion. I am especially appreciative that you indicate an understanding the tension here.

I understand that setting new default config options might not be possible on older releases that are technically only getting bugfixes, and no behavior changes would be allowed.

Our maintenance policy here is our guide here. We only release bug fixes to patch releases, and the 5-series is in maintenance-only mode now that the 6-series is the current major series. We avoid making enhancements to a stable branch like the 5.6 branch, so that users can rely on upgrading with minimal risk of an unstable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >enhancement v5.6.14
Projects
None yet
Development

No branches or pull requests

4 participants