Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GeoJSON Point format support for geo_point field value formats #47815

Closed
talevy opened this issue Oct 9, 2019 · 9 comments · Fixed by #85120
Closed

Add GeoJSON Point format support for geo_point field value formats #47815

talevy opened this issue Oct 9, 2019 · 9 comments · Fixed by #85120
Assignees
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@talevy
Copy link
Contributor

talevy commented Oct 9, 2019

Proposal

Support GeoJSON's Point type.

Existing Support

geo_point currently supports the following formats

  • "POINT(0 0)", WKT
  • { "lat": 0, "lon": 0}, lat/lon object
  • [0, 0], [lon, lat] array
  • "0, 0", (lat, lon) string
  • "gbsuv", geohash

Reason

Adding support for GeoJSON would make it easier to index the same field value as both geo_point and geo_shape when GeoJSON is preferred over WKT.

@talevy talevy added >enhancement :Analytics/Geo Indexing, search aggregations of geo points and shapes labels Oct 9, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

@talevy talevy changed the title Add GeoJSON support for geo_point field value formats Add GeoJSON Point format support for geo_point field value formats Oct 9, 2019
@nknize
Copy link
Contributor

nknize commented Nov 11, 2019

@talevy is this related to #47535?

@nknize
Copy link
Contributor

nknize commented Nov 11, 2019

@talevy is this related to #47535?

nvm.. I just saw it in the comments.

@talevy
Copy link
Contributor Author

talevy commented Nov 11, 2019

yeah... it took me a second to realize these are slightly different issues, where the other issue would supersede this one if done

@rjernst rjernst added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 4, 2020
@imotov
Copy link
Contributor

imotov commented Jun 25, 2020

@talevy do we still want to do that?

@talevy
Copy link
Contributor Author

talevy commented Jun 25, 2020

I, personally, do not see why this should not be supported. That being said, the silence on this issue reflects a lack of demand for this feature...

@imotov
Copy link
Contributor

imotov commented Jun 25, 2020

I think it should help consistency. I will keep it open for now, but we can discuss it in a team meeting if needed.

@jtibshirani
Copy link
Contributor

For consistency it would be great to add support for GeoJSON when indexing point fields as well.

@craigtaverner
Copy link
Contributor

This work is related to #84599 and there is now even a PR at #85120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants