Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make type checking only occur during semantic phase #49880

Closed
stu-elastic opened this issue Dec 5, 2019 · 2 comments
Closed

Make type checking only occur during semantic phase #49880

stu-elastic opened this issue Dec 5, 2019 · 2 comments
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache Team:Core/Infra Meta label for core/infra team

Comments

@stu-elastic
Copy link
Contributor

Type checking occurs in both the lexing phase and semantic phase. This leads to obtuse errors when caught in the lexing phase. Supporting both is also a maintenance burden. If the grammar were context free, we could do all type checking in the semantic phase and provide better error messages and clean up some code.

Migrated from: #31009
@stu-elastic stu-elastic added the :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache label Dec 5, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@rjernst rjernst added the needs:triage Requires assignment of a team area label label Dec 3, 2020
@jdconrad
Copy link
Contributor

jdconrad commented Dec 9, 2020

Done.

@jdconrad jdconrad closed this as completed Dec 9, 2020
@jdconrad jdconrad removed the needs:triage Requires assignment of a team area label label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache Team:Core/Infra Meta label for core/infra team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rjernst @jdconrad @elasticmachine @stu-elastic