Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve use of thread context propagation in CCR #89076

Open
DaveCTurner opened this issue Aug 3, 2022 · 1 comment
Open

Improve use of thread context propagation in CCR #89076

DaveCTurner opened this issue Aug 3, 2022 · 1 comment
Labels
:Distributed/CCR Issues around the Cross Cluster State Replication features Team:Distributed Meta label for distributed team >tech debt

Comments

@DaveCTurner
Copy link
Contributor

Today CCR sends its cross-cluster requests using a client which switches thread context to one with the right authorisation headers just before sending the request to the remote cluster (see e.g. CcrLicenseChecker#wrapClient). Instead we should run all the relevant code in the right thread context to begin with, and then just switch to a regular client. This would prevent surprises such as #61308 and #84409 and would also let us propagate other headers across clusters (e.g. for tracing).

@DaveCTurner DaveCTurner added :Distributed/CCR Issues around the Cross Cluster State Replication features >tech debt labels Aug 3, 2022
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label Aug 3, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/CCR Issues around the Cross Cluster State Replication features Team:Distributed Meta label for distributed team >tech debt
Projects
None yet
Development

No branches or pull requests

2 participants