Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork HdrHistogram library #95904

Open
martijnvg opened this issue May 8, 2023 · 6 comments
Open

Fork HdrHistogram library #95904

martijnvg opened this issue May 8, 2023 · 6 comments
Labels
:Analytics/Aggregations Aggregations :Delivery/Build Build or test infrastructure >refactoring Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Delivery Meta label for Delivery team

Comments

@martijnvg
Copy link
Member

We plan to fork the HdrHistogram library.

There are two main reasons behind this choice:

  1. We would like to control semantic version and backward compatibility according to our definition. Right now, for instance, TDigest does not match our usage of semantic versioning when changing the library code and that makes upgrading quite challenging because exposes us to backward compatibility issues.
  2. We would like to change those libraries to use some specific Elasticsearch libraries/tools/frameworks such as BigArrays. Right now when running some aggregations (percentiles, boxplot,...) we experience OOMs due to large memory usage. Using BigArrays, for instance, would allow us to deal with OOMs using Circuit Breakers.

The immediate goal is just to fork and then later enhance the forked library to make use of big arrays infrastructure.
@martijnvg martijnvg added :Delivery/Build Build or test infrastructure :Analytics/Aggregations Aggregations >refactoring labels May 8, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Delivery Meta label for Delivery team labels May 8, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@martijnvg martijnvg mentioned this issue May 8, 2023
Closed
@kkrik-es kkrik-es self-assigned this May 8, 2023
@mark-vieira
Copy link
Contributor

Closed by #95903.

@martijnvg
Copy link
Member Author

This hasn't been completed yet. Only t-digest library has been forked, but not yet the HDR histogram library.

@martijnvg martijnvg reopened this Oct 5, 2023
@mark-vieira
Copy link
Contributor

This hasn't been completed yet. Only t-digest library has been forked, but not yet the HDR histogram library.

Sorry about that, I misread the discussion as being we weren't going to fork this and only t-digest.

@martijnvg martijnvg mentioned this issue Mar 11, 2024
Open
11 tasks
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations :Delivery/Build Build or test infrastructure >refactoring Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Delivery Meta label for Delivery team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@martijnvg @mark-vieira @elasticsearchmachine @kkrik-es