Final EuiDataGrid VRT updates

elastic · Sep 10, 2024 · 34eb709 · 34eb709
1 parent 6e15e64
commit 34eb709
Show file tree

Hide file tree

Showing 22 changed files with 4 additions and 3 deletions.
diff --git a/.../reference/chrome_desktop_Tabular_Content_EuiDataGrid_Custom_Header_Content.png b/.../reference/chrome_desktop_Tabular_Content_EuiDataGrid_Custom_Header_Content.png
diff --git a/...e_desktop_Tabular_Content_EuiDataGrid_FullscreenVRT_Full_Screen_With_Flyout.png b/...e_desktop_Tabular_Content_EuiDataGrid_FullscreenVRT_Full_Screen_With_Flyout.png
diff --git a/...e_desktop_Tabular_Content_EuiDataGrid_FullscreenVRT_Full_Screen_With_Header.png b/...e_desktop_Tabular_Content_EuiDataGrid_FullscreenVRT_Full_Screen_With_Header.png
diff --git a/...s/eui/.loki/reference/chrome_desktop_Tabular_Content_EuiDataGrid_Playground.png b/...s/eui/.loki/reference/chrome_desktop_Tabular_Content_EuiDataGrid_Playground.png
diff --git a/...i/.loki/reference/chrome_desktop_Tabular_Content_EuiDataGrid_Virtualization.png b/...i/.loki/reference/chrome_desktop_Tabular_Content_EuiDataGrid_Virtualization.png
diff --git a/...reference/chrome_desktop_Tabular_Content_EuiDataGrid_gridStyle_prop_Compact.png b/...reference/chrome_desktop_Tabular_Content_EuiDataGrid_gridStyle_prop_Compact.png
diff --git a/..._desktop_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Column_Selector.png b/..._desktop_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Column_Selector.png
diff --git a/...e_desktop_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Column_Sorting.png b/...e_desktop_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Column_Sorting.png
diff --git a/...desktop_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Display_Selector.png b/...desktop_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Display_Selector.png
diff --git a/...sktop_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Full_Screen_Toggle.png b/...sktop_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Full_Screen_Toggle.png
diff --git a/...sktop_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Keyboard_Shortcuts.png b/...sktop_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Keyboard_Shortcuts.png
diff --git a/...i/reference/chrome_mobile_Tabular_Content_EuiDataGrid_Custom_Header_Content.png b/...i/reference/chrome_mobile_Tabular_Content_EuiDataGrid_Custom_Header_Content.png
diff --git a/...me_mobile_Tabular_Content_EuiDataGrid_FullscreenVRT_Full_Screen_With_Flyout.png b/...me_mobile_Tabular_Content_EuiDataGrid_FullscreenVRT_Full_Screen_With_Flyout.png
diff --git a/...me_mobile_Tabular_Content_EuiDataGrid_FullscreenVRT_Full_Screen_With_Header.png b/...me_mobile_Tabular_Content_EuiDataGrid_FullscreenVRT_Full_Screen_With_Header.png
diff --git a/...es/eui/.loki/reference/chrome_mobile_Tabular_Content_EuiDataGrid_Playground.png b/...es/eui/.loki/reference/chrome_mobile_Tabular_Content_EuiDataGrid_Playground.png
diff --git a/...e_mobile_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Column_Selector.png b/...e_mobile_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Column_Selector.png
diff --git a/...me_mobile_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Column_Sorting.png b/...me_mobile_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Column_Sorting.png
diff --git a/..._mobile_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Display_Selector.png b/..._mobile_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Display_Selector.png
diff --git a/...obile_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Full_Screen_Toggle.png b/...obile_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Full_Screen_Toggle.png
diff --git a/...obile_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Keyboard_Shortcuts.png b/...obile_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Keyboard_Shortcuts.png
diff --git a/packages/eui/.storybook/loki.ts b/packages/eui/.storybook/loki.ts
@@ -25,7 +25,7 @@ export const LOKI_SELECTORS = {
   /**
    * Portal element content selector
    */
-  portal: '#storybook-root',
+  portal: '#storybook-root > *',
 } as const;
 
 /**

diff --git a/packages/eui/src/components/datagrid/controls/full_screen_selector.stories.tsx b/packages/eui/src/components/datagrid/controls/full_screen_selector.stories.tsx
@@ -7,7 +7,7 @@
  */
 
 import React, { useState } from 'react';
-import { fireEvent, within } from '@storybook/test';
+import { fireEvent, waitFor, within } from '@storybook/test';
 import type { Meta, StoryObj, ReactRenderer } from '@storybook/react';
 import type { PlayFunctionContext } from '@storybook/csf';
 import { LOKI_SELECTORS } from '../../../../.storybook/loki';
@@ -47,7 +47,7 @@ const dataGridProps: EuiDataGridProps = {
 export const FullScreenWithHeader: Story = {
   tags: ['vrt-only'],
   parameters: {
-    loki: { chromeSelector: LOKI_SELECTORS.body },
+    loki: { chromeSelector: LOKI_SELECTORS.portal },
   },
   render: () => (
     <>
@@ -59,6 +59,7 @@ export const FullScreenWithHeader: Story = {
   ),
   play: async ({ canvasElement }: PlayFunctionContext<ReactRenderer>) => {
     const canvas = within(canvasElement);
+    await waitFor(() => canvas.getByLabelText('Enter fullscreen'));
     await fireEvent.click(canvas.getByLabelText('Enter fullscreen'));
   },
 };