Skip to content

Commit

Permalink
[PR feedback] Prop name +
Browse files Browse the repository at this point in the history
Use the full `refreshMinInterval` prop for EuiSuperDatePicker subcomponents - we use `minInterval` for the refresh component directly

+ unify types
  • Loading branch information
cee-chen committed Jul 23, 2024
1 parent 0a389db commit a739946
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ export interface EuiQuickSelectPopoverProps {
isDisabled: boolean;
isPaused: boolean;
recentlyUsedRanges: DurationRange[];
refreshInterval: number;
minInterval?: Milliseconds;
refreshInterval: Milliseconds;
refreshMinInterval?: Milliseconds;
intervalUnits?: RefreshUnitsOptions;
start: string;
timeOptions: TimeOptions;
Expand Down Expand Up @@ -139,7 +139,7 @@ export const EuiQuickSelectPanels: FunctionComponent<
customQuickSelectRender,
isPaused,
refreshInterval,
minInterval,
refreshMinInterval,
intervalUnits,
applyRefreshInterval,
applyTime,
Expand Down Expand Up @@ -176,7 +176,7 @@ export const EuiQuickSelectPanels: FunctionComponent<
onRefreshChange={applyRefreshInterval}
isPaused={isPaused}
refreshInterval={refreshInterval}
minInterval={minInterval}
minInterval={refreshMinInterval}
intervalUnits={intervalUnits}
/>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ export class EuiSuperDatePickerInternal extends Component<
isPaused={isPaused}
recentlyUsedRanges={recentlyUsedRanges}
refreshInterval={refreshInterval}
minInterval={refreshMinInterval}
refreshMinInterval={refreshMinInterval}
intervalUnits={refreshIntervalUnits}
start={start}
timeOptions={timeOptions}
Expand Down

0 comments on commit a739946

Please sign in to comment.