From c11b1cd2f1b744137e6d9cecedb6a8a5d7771142 Mon Sep 17 00:00:00 2001 From: Ryan Keairns Date: Thu, 6 Sep 2018 12:49:00 -0500 Subject: [PATCH] switch default to true --- CHANGELOG.md | 1 + src-docs/src/views/modal/modal.js | 2 +- src-docs/src/views/modal/modal_example.js | 2 +- src-docs/src/views/modal/overflow_test.js | 1 - .../modal/__snapshots__/confirm_modal.test.js.snap | 2 +- src/components/modal/__snapshots__/modal.test.js.snap | 2 +- src/components/modal/modal.js | 6 +++--- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6de915d9357..03518e36ac2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ ## [`master`](https://github.com/elastic/eui/tree/master) +- Added `maxWidth` prop to `EuiModal` ([#1165](https://github.com/elastic/eui/pull/1165)) - Added `infraApp` icon ([#1161](https://github.com/elastic/eui/pull/1161)) - Added sizes to `EuiButtonIcon` ([#1145](https://github.com/elastic/eui/pull/1145)) - Added `singleSelection.asPlainText` prop to `EuiComboBox` ([#1139](https://github.com/elastic/eui/pull/1139)) diff --git a/src-docs/src/views/modal/modal.js b/src-docs/src/views/modal/modal.js index d512ae06c69..a93a2e5065d 100644 --- a/src-docs/src/views/modal/modal.js +++ b/src-docs/src/views/modal/modal.js @@ -87,7 +87,7 @@ export class Modal extends Component { diff --git a/src-docs/src/views/modal/modal_example.js b/src-docs/src/views/modal/modal_example.js index 2ef36a73a22..59ade118ce5 100644 --- a/src-docs/src/views/modal/modal_example.js +++ b/src-docs/src/views/modal/modal_example.js @@ -72,7 +72,7 @@ export const ModalExample = { }], text: (

- This demo is to test long overflowing body content. It also demonstrates the maxWidth property. + This demo is to test long overflowing body content.

), props: { EuiConfirmModal }, diff --git a/src-docs/src/views/modal/overflow_test.js b/src-docs/src/views/modal/overflow_test.js index cf485bac110..632fff82f54 100644 --- a/src-docs/src/views/modal/overflow_test.js +++ b/src-docs/src/views/modal/overflow_test.js @@ -50,7 +50,6 @@ export class OverflowTest extends Component { diff --git a/src/components/modal/__snapshots__/confirm_modal.test.js.snap b/src/components/modal/__snapshots__/confirm_modal.test.js.snap index 76334af75e4..65e833cc519 100644 --- a/src/components/modal/__snapshots__/confirm_modal.test.js.snap +++ b/src/components/modal/__snapshots__/confirm_modal.test.js.snap @@ -4,7 +4,7 @@ exports[`renders EuiConfirmModal 1`] = `
diff --git a/src/components/modal/__snapshots__/modal.test.js.snap b/src/components/modal/__snapshots__/modal.test.js.snap index fb8405d6953..df1782bfddd 100644 --- a/src/components/modal/__snapshots__/modal.test.js.snap +++ b/src/components/modal/__snapshots__/modal.test.js.snap @@ -4,7 +4,7 @@ exports[`renders EuiModal 1`] = `
diff --git a/src/components/modal/modal.js b/src/components/modal/modal.js index e16718c743a..70e002552dd 100644 --- a/src/components/modal/modal.js +++ b/src/components/modal/modal.js @@ -79,8 +79,8 @@ EuiModal.propTypes = { onClose: PropTypes.func.isRequired, /** * Sets the max-width of the modal. - * Set to `false` to not restrict the width, - * set to `true` to use the default (`euiBreakpoints 'm'`), + * Set to `true` to use the default (`euiBreakpoints 'm'`), + * set to `false` to not restrict the width, * set to a number for a custom width in px, * set to a string for a custom width in custom measurement. */ @@ -92,5 +92,5 @@ EuiModal.propTypes = { }; EuiModal.defaultProps = { - maxWidth: false, + maxWidth: true, };