Skip to content

Commit

Permalink
[EuiMarkdownEditor] Fix styling for Amsterdam (#4289)
Browse files Browse the repository at this point in the history
* Adding amsterdam styles for markdown editor

* CL and removing outline for edge, firefox and safari.

* Update src/themes/eui-amsterdam/overrides/_index.scss

Co-authored-by: Caroline Horn <[email protected]>

* Addressing PR review

* CL

Co-authored-by: Caroline Horn <[email protected]>
  • Loading branch information
miukimiu and cchaos committed Nov 20, 2020
1 parent 7cdafea commit d5f5d6f
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 10 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

- Fixed initial focus of an `EuiButtonGroup` when first item in a popover ([#4288](https://github.com/elastic/eui/pull/4288))

**Theme: Amsterdam**

- Fixed styles for `EuiMarkdownEditor` ([#4289](https://github.com/elastic/eui/pull/4289))

## [`30.4.1`](https://github.com/elastic/eui/tree/v30.4.1)

- Exported `useDataGridColumnSelector`, `useDataGridColumnSorting`, and `useDataGridStyleSelector` hooks ([#4271](https://github.com/elastic/eui/pull/4271))
Expand Down
1 change: 0 additions & 1 deletion src/components/markdown_editor/_index.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
@import 'markdown_editor';
@import 'markdown_editor_drop_zone';
@import 'markdown_format';
@import 'markdown_editor_footer';
Expand Down
8 changes: 0 additions & 8 deletions src/components/markdown_editor/_markdown_editor.scss

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
.euiMarkdownEditorDropZone {
@include euiFormControlDefaultShadow;
display: flex;
position: relative;
flex-direction: column;
Expand Down
1 change: 1 addition & 0 deletions src/themes/eui-amsterdam/overrides/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
@import 'header';
@import 'image';
@import 'mark';
@import 'markdown_editor';
@import 'modal';
@import 'overlay_mask';
@import 'popover';
Expand Down
18 changes: 18 additions & 0 deletions src/themes/eui-amsterdam/overrides/_markdown_editor.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
.euiMarkdownEditorToolbar {
border-radius: $euiFormControlBorderRadius $euiFormControlBorderRadius 0 0;
}

.euiMarkdownEditorTextArea {
&:focus {
outline: none;
}

&:focus:focus-visible {
outline-style: none;
}
}

.euiMarkdownEditorPreview,
.euiMarkdownEditorFooter {
border-radius: 0 0 $euiFormControlBorderRadius $euiFormControlBorderRadius;
}

0 comments on commit d5f5d6f

Please sign in to comment.