From fde22a8baec0bbd7eb899abbe9742c399d597fd3 Mon Sep 17 00:00:00 2001 From: Theofanis Despoudis Date: Thu, 4 Apr 2019 16:38:58 +0100 Subject: [PATCH] Converted `EuiTableHeaderMobile` to TS (#1786) * [Pagination] - Updated Changelog * Code Review - Moved Changelog entry to current master * [META] - Converted to TS + tests * Code review fixes * [META] - Converted to TS * Updated Changelog * EuiFormErrorText - Code review fixes * Converted `EuiTableHeaderMobile` to TS + tests * Updated Changelog * Updated Changelog entry for EuiTableHeaderMobile * EuiTableHeaderMobile: Code review fixes --- CHANGELOG.md | 3 +-- src/components/table/index.d.ts | 1 + ...snap => table_header_mobile.test.tsx.snap} | 0 src/components/table/mobile/index.d.ts | 1 + .../table/mobile/table_header_mobile.js | 25 ------------------- ...e.test.js => table_header_mobile.test.tsx} | 7 ++---- .../table/mobile/table_header_mobile.tsx | 15 +++++++++++ 7 files changed, 20 insertions(+), 32 deletions(-) rename src/components/table/mobile/__snapshots__/{table_header_mobile.test.js.snap => table_header_mobile.test.tsx.snap} (100%) create mode 100644 src/components/table/mobile/index.d.ts delete mode 100644 src/components/table/mobile/table_header_mobile.js rename src/components/table/mobile/{table_header_mobile.test.js => table_header_mobile.test.tsx} (65%) create mode 100644 src/components/table/mobile/table_header_mobile.tsx diff --git a/CHANGELOG.md b/CHANGELOG.md index ed10f99450b..736c5520c52 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,13 +1,12 @@ ## [`master`](https://github.com/elastic/eui/tree/master) -No public interface changes since `9.8.0`. +- Converted `EuiTableHeaderMobile` to TS ([#1786](https://github.com/elastic/eui/pull/1786)) ## [`9.8.0`](https://github.com/elastic/eui/tree/v9.8.0) - **[Beta]** Added new `EuiSelectable` component ([#1699](https://github.com/elastic/eui/pull/1699)) - **[Beta]** Added new drag and drop components: `EuiDragDropContext`, `EuiDraggable`, and `EuiDroppable` ([#1733](https://github.com/elastic/eui/pull/1733)) - ## [`9.7.2`](https://github.com/elastic/eui/tree/v9.7.2) - Converted `EuiFormErrorText` to TS ([#1772](https://github.com/elastic/eui/pull/1772)) diff --git a/src/components/table/index.d.ts b/src/components/table/index.d.ts index 755818abd8b..47a2b97c4a7 100644 --- a/src/components/table/index.d.ts +++ b/src/components/table/index.d.ts @@ -1,4 +1,5 @@ /// +/// import { CommonProps, NoArgCallback } from '../common'; import { IconType } from '../icon'; import { HorizontalAlignment } from '../../services/alignment'; diff --git a/src/components/table/mobile/__snapshots__/table_header_mobile.test.js.snap b/src/components/table/mobile/__snapshots__/table_header_mobile.test.tsx.snap similarity index 100% rename from src/components/table/mobile/__snapshots__/table_header_mobile.test.js.snap rename to src/components/table/mobile/__snapshots__/table_header_mobile.test.tsx.snap diff --git a/src/components/table/mobile/index.d.ts b/src/components/table/mobile/index.d.ts new file mode 100644 index 00000000000..a54d79c7147 --- /dev/null +++ b/src/components/table/mobile/index.d.ts @@ -0,0 +1 @@ +export { EuiTableHeaderMobile } from './table_header_mobile'; diff --git a/src/components/table/mobile/table_header_mobile.js b/src/components/table/mobile/table_header_mobile.js deleted file mode 100644 index ac1d855fa47..00000000000 --- a/src/components/table/mobile/table_header_mobile.js +++ /dev/null @@ -1,25 +0,0 @@ -import React from 'react'; -import PropTypes from 'prop-types'; -import classNames from 'classnames'; - -export const EuiTableHeaderMobile = ({ - children, - className, - ...rest, -}) => { - const classes = classNames('euiTableHeaderMobile', className); - - return ( -
- {children} -
- ); -}; - -EuiTableHeaderMobile.propTypes = { - children: PropTypes.node, - className: PropTypes.string, -}; diff --git a/src/components/table/mobile/table_header_mobile.test.js b/src/components/table/mobile/table_header_mobile.test.tsx similarity index 65% rename from src/components/table/mobile/table_header_mobile.test.js rename to src/components/table/mobile/table_header_mobile.test.tsx index 1aa94791d96..c674d3ff8af 100644 --- a/src/components/table/mobile/table_header_mobile.test.js +++ b/src/components/table/mobile/table_header_mobile.test.tsx @@ -6,11 +6,8 @@ import { EuiTableHeaderMobile } from './table_header_mobile'; describe('EuiTableHeaderMobile', () => { test('is rendered', () => { - const component = render( - - ); + const component = render(); - expect(component) - .toMatchSnapshot(); + expect(component).toMatchSnapshot(); }); }); diff --git a/src/components/table/mobile/table_header_mobile.tsx b/src/components/table/mobile/table_header_mobile.tsx new file mode 100644 index 00000000000..b43fee162b2 --- /dev/null +++ b/src/components/table/mobile/table_header_mobile.tsx @@ -0,0 +1,15 @@ +import React, { FunctionComponent, HTMLAttributes } from 'react'; +import classNames from 'classnames'; +import { CommonProps } from '../../common'; + +export const EuiTableHeaderMobile: FunctionComponent< + CommonProps & HTMLAttributes +> = ({ children, className, ...rest }) => { + const classes = classNames('euiTableHeaderMobile', className); + + return ( +
+ {children} +
+ ); +};