Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the drag'n'drop types #2172

Closed
timroes opened this issue Jul 26, 2019 · 0 comments · Fixed by #2173
Closed

Export the drag'n'drop types #2172

timroes opened this issue Jul 26, 2019 · 0 comments · Fixed by #2173

Comments

@timroes
Copy link
Contributor

timroes commented Jul 26, 2019

We currently don't export any of the drag'n'drop types that will be passed into the drag'n'drop callback methods a user needs to specify. That causes people to do produce code that either contains any: https://github.com/elastic/kibana/pull/40866/files#diff-5196c51faa9492fb15b9d72ffd692ee3R109 or write some complex helper utilities to get those (https://github.com/elastic/kibana/blob/master/x-pack/legacy/common/eui_draggable/index.d.ts#L17). I think it would make sense to export DropResult and the other parameters that will be passed into the drag'n'drop handlers from EUI directly (so we abstract away from the underlying React DnD library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants