Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiSwitch does not put data-test-subj attribute on input #225

Closed
nreese opened this issue Dec 19, 2017 · 1 comment
Closed

EuiSwitch does not put data-test-subj attribute on input #225

nreese opened this issue Dec 19, 2017 · 1 comment

Comments

@nreese
Copy link
Contributor

nreese commented Dec 19, 2017

       <EuiSwitch
          label="Multiselect"
          checked={props.controlParams.options.multiselect}
          onChange={handleMultiselectChange}
          data-test-subj="listControlMultiselectInput"
        />

Notice that the data-test-subj attribute is put on the div instead of the input

screen shot 2017-12-19 at 4 04 40 pm

cc @elastic/kibana-design

@uboness
Copy link
Contributor

uboness commented Dec 23, 2017

I noticed that this is a consistent behaviour for many/all controls... the ...rest props are applied on the wrapping div

@snide snide closed this as completed in #246 Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants