Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled EuiLink styled like regular EuiLink #2361

Closed
flash1293 opened this issue Sep 23, 2019 · 3 comments · Fixed by #2423
Closed

Disabled EuiLink styled like regular EuiLink #2361

flash1293 opened this issue Sep 23, 2019 · 3 comments · Fixed by #2423

Comments

@flash1293
Copy link
Contributor

A <EuiLink onClick={...} disabled ... /> is styled exactly as a regular EuiLink. Also, the cursor is still a pointer.

Example:
Screenshot 2019-09-23 at 15 57 22

Maybe this is intentional, but it feels like the link should visually reflect somehow that it can't be clicked right now.

@cchaos
Copy link
Contributor

cchaos commented Sep 23, 2019

Semantically this is correct since Links (anchor tags) don't technically have a disabled state. However, you're using these as buttons but just styled as inline links. I'll add this to discuss this week.

@flash1293
Copy link
Contributor Author

Valid point, maybe EuiLink shouldn't accept a disabled prop at all. The use case of disabling a button looking like a link is questionable - maybe the whole UI should look different then.

@cchaos
Copy link
Contributor

cchaos commented Sep 24, 2019

We discussed this in our weekly and have decided that if disabled is passed to an EuiLink (which it inherits the prop from the default properties of <button>) then we will just remove the link coloring and hover states to make it blend into (inherit the color of) the text surrounding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants