Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiTreeView] Add ability to use href #2492

Closed
snide opened this issue Oct 25, 2019 · 5 comments
Closed

[EuiTreeView] Add ability to use href #2492

snide opened this issue Oct 25, 2019 · 5 comments

Comments

@snide
Copy link
Contributor

snide commented Oct 25, 2019

Currently the tree view only allows onClicks through a callback. The component lends itself to being a decent sidenav as well. We should add the ability to add href links to tree elements.

#2409

@myasonik
Copy link
Contributor

If EuiTreeView starts to except links, what's the line between it and EuiSideNav?

What I'm really concerned about it semantics (surprise!), what's a <nav> and what isn't? What's a role=tree and what's just a list, or a list of lists?

None of these things are insurmountable, just things to stay cognizant of when extending EuiTreeView.

@mridulgogia
Copy link
Contributor

Can I work on it?

@myasonik
Copy link
Contributor

We don't have a plan in place for how we want this component to look in the future and how it will differentiate itself from EuiSideNav so figuring that out is the first step.

If you have any proposals, we can discus them here before digging into the code.

@cchaos cchaos added ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible discussion and removed ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible labels Mar 18, 2020
@cchaos cchaos changed the title Tree view: Add ability to use href [EuiTreeView] Add ability to use href Mar 18, 2020
@snide snide mentioned this issue Mar 9, 2021
41 tasks
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants