Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiInMemoryTable] Needs to document its itemId prop #3381

Closed
chandlerprall opened this issue Apr 23, 2020 · 0 comments · Fixed by #4617
Closed

[EuiInMemoryTable] Needs to document its itemId prop #3381

chandlerprall opened this issue Apr 23, 2020 · 0 comments · Fixed by #4617
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries good first issue

Comments

@chandlerprall
Copy link
Contributor

This has confused me and at least 2 other devs. EuiInMemoryTable requires a selection prop and an itemId prop to enable selection. The only way to know this is looking at the Demo JS tab, spotting the itemId line, and recognizing it is important. Without itemId selection looks like it should be working but it mysteriously doesn't. Information about the necessary props should be included directly in the page's copy.

@chandlerprall chandlerprall added documentation Issues or PRs that only affect documentation - will not need changelog entries tables good first issue labels Apr 23, 2020
@cchaos cchaos changed the title EuiInMemoryTable needs to document its itemId prop [EuiInMemoryTable] Needs to document its itemId prop Sep 19, 2020
@cchaos cchaos removed the tables label Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants