Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card icon property does not take type null #3459

Closed
sarahetter opened this issue May 11, 2020 · 1 comment · Fixed by #3470
Closed

Card icon property does not take type null #3459

sarahetter opened this issue May 11, 2020 · 1 comment · Fixed by #3470
Labels
feature request good first issue

Comments

@sarahetter
Copy link

The acceptable types for EuiCard are either a React Component or undefined. We're using a function to get the Icon component. Sometimes we (in Cloud) do not want to display an icon, which is typically done by returning null.

Can null be added as an accepted type?
@chandlerprall
Copy link
Contributor

Agreed! Let's widen that type to support nulls

This was referenced May 12, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added null as acceptable icon for EuiCard anishagg17/eui
2 participants
@chandlerprall @sarahetter