-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiTableCell] Default table cell alignment in Safari is mixed #4568
Comments
Can we get a copy/paste of the actual implementation code, or at lease the rendered cell DOM? I feel like this may be specific to the inner child. |
The linked PR provides more context. There are some interesting details in there. |
In that PR it looks like the root of problem was tracked to the specific content:
|
I tinkered with the markup, briefly, and it didn't seem to be the culprit. Also, the first example in the EUI docs site shows the same result on Safari: |
👍 Ugh, just another place where Safari is way too heavy-handed with their default browser styles. |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
I'll try to tackle this fix as part of the new Emotion global styles. |
I found that the root of the problem was when we converted the first column from rendering a |
In elastic/kibana#92374 , it was noted that the table cell content alignment is inconsistent on Safari. Using the
align
prop works forright
andcenter
, as that applies an explicit class, butleft
andstart
appear to have no effect (i.e. they are left to the browser default, I suspect).In effect, this means you cannot reliably for a left/start alignment on Safari. The likely code in question is below:
eui/src/components/table/_table.scss
Lines 141 to 162 in 5270286
Screenshot from Safari
The text was updated successfully, but these errors were encountered: