Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiComboBox] Fixed options list misalignment #4607

Merged
merged 4 commits into from
Mar 5, 2021

Conversation

wenchonglee
Copy link
Contributor

@wenchonglee wenchonglee commented Mar 4, 2021

Summary

Fixes #4472.

@chandlerprall explained how to reproduce the problem and why it is happening
#4472 (comment)

To test it on the docs page, use devtools to manually remove enough elements so that only 1 EuiComboBox is left, then mimic the clip shared in the issue.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
    - [ ] Props have proper autodocs and playground toggles
    - [ ] Added documentation
    - [ ] Checked Code Sandbox works for the any docs examples
    - [ ] Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@wenchonglee wenchonglee changed the title Fixed EuiComboBox options list misalignment [EuiComboBox] Fixed options list misalignment Mar 4, 2021
@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4607/

@thompsongl
Copy link
Contributor

jenkins test this

Somewhat confused about the cause of this snapshot failure:

-  style="top: 16px; left: -22px; z-index: 2000; will-change: transform, opacity;"
+  style="top: 16px; left: -22px; will-change: transform, opacity; z-index: 2000;"

@cchaos
Copy link
Contributor

cchaos commented Mar 4, 2021

This isn't up to date with master. That change came from #4590

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4607/

@wenchonglee
Copy link
Contributor Author

Hmm, that was weird, I thought I was up to date at the time of submitting this PR. Please try again, I've tried running the test locally this time.

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4607/

@thompsongl
Copy link
Contributor

Running CI again to be safe

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4607/

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @wenchonglee!

CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiComboBox] Misaligned options list
4 participants