Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Need to handle better "no data" scenarios and loading states #5026

Closed
1 task done
Tracked by #85965
miukimiu opened this issue Aug 13, 2021 · 4 comments
Closed
1 task done
Tracked by #85965
Labels
data grid documentation Issues or PRs that only affect documentation - will not need changelog entries feature request stale-issue stale-issue-closed

Comments

@miukimiu
Copy link
Contributor

miukimiu commented Aug 13, 2021

Screenshot 2021-08-13 at 14 51 27

As we can see from the screenshot (https://codesandbox.io/s/datagrid-header-forked-svk7y?file=/index.js:2560-2571) when no data is available the EuiDataGrid only show the header cells, toolbar and pagination.

This behavior can look like a bug. Users don't know why is the header cells showing, why is the pagination clickable but they can't see any data.

So, we should fix the design to better handle "no data" scenarios.

Design improvement

  • We should provide a default empty state (just a text?) and probably a way to customize the text. If there's pagination and no data, the pagination should get disabled.
  • Also we should provide some loading states and handle better how cells are loaded on scroll.
  • We need guidelines for loading, empty states, and results.

Bug to fix

@miukimiu
Copy link
Contributor Author

Example of the current EuiDataGrid loading new data:

Screen.Recording.2021-08-17.at.04.54.PM.mov

@miukimiu miukimiu self-assigned this Aug 20, 2021
@miukimiu miukimiu changed the title [EuiDataGrid] Need to handle better "no data" scenarios [EuiDataGrid] Need to handle better "no data" scenarios and need loading states Sep 16, 2021
@miukimiu miukimiu changed the title [EuiDataGrid] Need to handle better "no data" scenarios and need loading states [EuiDataGrid] Need to handle better "no data" scenarios and loading states Sep 20, 2021
@flash1293
Copy link
Contributor

Especially for tables on a dashboard, adding a central app-controlled UI element would be helpful, also wrt aligning tables with other chart types:
Screenshot 2022-07-14 at 13 25 35

Please add an option to render a react element centered over the grid as part of this issue

@miukimiu miukimiu added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Feb 28, 2023
@cee-chen cee-chen removed the bug label Apr 3, 2023
@github-actions
Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

Copy link

❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data grid documentation Issues or PRs that only affect documentation - will not need changelog entries feature request stale-issue stale-issue-closed
Projects
None yet
Development

No branches or pull requests

3 participants