Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid][KEYBOARD]: Buttons must be able to receive keyboard focus in table rows #5238

Closed
Tracked by #85965
1Copenut opened this issue Oct 4, 2021 · 2 comments

Comments

@1Copenut
Copy link
Contributor

1Copenut commented Oct 4, 2021

UPDATE
The EUI team was discussing another aspect of data grid navigation, and linked to the WAI-ARIA Authoring Practices for Data Grid keyboard navigation. The section on grid cell navigation was new information, and highly relevant to this issue.

Specifically I'd like to explore using the F2 key to place focus on the first <button> element and allow users to navigate widgets inside the cell using the TAB key or SHIFT + TAB to traverse backwards by focusable elements. Pressing ESC would return users to the standard data grid navigation by arrow keys.

Steps to reproduce

  1. Start a Kibana data set with tables that include inline buttons or filters
  2. Tab to the table, then use arrow keys to navigate through cells
  3. Verify pressing TAB in the focused cell does not set keyboard focus on a button in the cell.
  4. Current focus can be tested easily in developer tools by typing document.activeElement in the console

Screen Shot 2021-10-04 at 4 14 31 PM

Actual Result

  • The inline buttons are ignored in the focus order

Expected Result

  • Buttons of the focused table cell will receive keyboard focus before focus is set out of the table

Kibana Version:
v8.0.0

OS:
MacOS Big Sur

Browser:
Chrome

Relevant WCAG Criteria:
Understanding Success Criterion 2.1.1: Keyboard - Level A

@elasticmachine
Copy link
Collaborator

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@1Copenut 1Copenut changed the title (Accessibility) [KEYBOARD]: Buttons must be able to receive keyboard focus in table rows Oct 4, 2021
@1Copenut 1Copenut transferred this issue from elastic/kibana Oct 4, 2021
@1Copenut 1Copenut added accessibility accessibility - WCAG A Level A WCAG Accessibility Criteria labels Oct 4, 2021
@cee-chen cee-chen changed the title [KEYBOARD]: Buttons must be able to receive keyboard focus in table rows [EuiDataGrid][KEYBOARD]: Buttons must be able to receive keyboard focus in table rows Oct 4, 2021
@1Copenut
Copy link
Contributor Author

1Copenut commented Dec 9, 2021

I'm going to close this issue. After a discussion with @chandlerprall I learned our data grid cells have the ability to set focus on buttons by pressing ENTER or F2. The focusable items (if multiple) are enabled in a popover, or if the cell contains no focusable elements, the cell data is shown in the popover. Verified this on a cloud instance of Kibana, v7.16.0. Moving to close.

@1Copenut 1Copenut closed this as completed Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants