Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDataGrid][KEYBOARD]: Update data grid control cells' focus halo to same blue as other cells #5479

Closed
Tracked by #85965
1Copenut opened this issue Dec 15, 2021 · 2 comments · Fixed by #5522
Closed
Tracked by #85965

[EuiDataGrid][KEYBOARD]: Update data grid control cells' focus halo to same blue as other cells #5479

1Copenut opened this issue Dec 15, 2021 · 2 comments · Fixed by #5522
Labels
accessibility - keyboard accessibility data grid good first issue

Comments

@1Copenut
Copy link
Contributor

While testing the new Discover data grid, I noticed the control columns were using a black focus halo for the checkboxes and flyout control. I wanted to ask if it made sense to make this focus halo blue for consistency with other cells.

Screen Shot 2021-12-15 at 5 02 14 PM
@1Copenut 1Copenut mentioned this issue Dec 15, 2021
Closed
41 tasks
@miukimiu
Copy link
Contributor

@1Copenut yes, it would make sense. It creates more consistency.

@1Copenut 1Copenut changed the title [EuiDataGrid][KEYBOARD]: Would it make sense to make control cells' focus halo blue? [EuiDataGrid][KEYBOARD]: Update data grid control cells' focus halo to same blue as other cells Dec 16, 2021
@Al-0
Copy link
Contributor

Al-0 commented Jan 7, 2022

Hi, I will submit a PR to fix this!

@Al-0 Al-0 mentioned this issue Jan 7, 2022
Merged
8 tasks
@thompsongl thompsongl mentioned this issue Jan 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility - keyboard accessibility data grid good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EuiDataGrid] Fix inconsistent focus halo Al-0/eui
3 participants
@1Copenut @miukimiu @Al-0