Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removing momentjs dependency #5879

Closed
Baldauf opened this issue May 5, 2022 · 4 comments
Closed

Investigate removing momentjs dependency #5879

Baldauf opened this issue May 5, 2022 · 4 comments

Comments

@Baldauf
Copy link

Baldauf commented May 5, 2022

There are a number of reasons EUI should consider moving away from momentjs, including:

  • its global state creates usage hurdles and hard-to-predict code interactions
  • there are newer popular date/time libraries which take advantage of newer browser APIs
  • momentjs's bundle size isn't insignificant

This thinking aligns with moment's project status page. However, it would be a significant breaking change that would need coordination between internal Elastic teams as well as good communication leading up to changes for outside community users & contributors to respond to.

First steps in the process will be to audit EUI's usage of momentjs and compare that with potential replacement libraries' functionality.

@chandlerprall
Copy link
Contributor

I do expect to see that change in a future version, but there are no plans to do so and that change will need to have larger coordination with other Elastic product teams. We won't be able to explore this change until after our conversion to Emotion (#5685), but it has been a growing source of technical debt and overall a buzzkill knowing there's modern, recommended solutions.

Do you mind if I repurpose this issue (edit the title&description) to track the idea?

@Baldauf
Copy link
Author

Baldauf commented May 6, 2022

Thanks for the insight. Yes, @chandlerprall please modify as you wish!

@chandlerprall chandlerprall changed the title Are there any plans to remove the moment.js dependency? Investigate removing momentjs dependency Jun 3, 2022
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants