Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable key width on EuiKeyPadMenu #6094

Closed
sksamuel opened this issue Aug 1, 2022 · 4 comments
Closed

Customizable key width on EuiKeyPadMenu #6094

sksamuel opened this issue Aug 1, 2022 · 4 comments
Labels
answered Issues answered by the EUI team - auto-closes open issues in 7 days if no follow-up response emotion

Comments

@sksamuel
Copy link

sksamuel commented Aug 1, 2022

As the title says, would be great to allow 4/5 or more columns in the EuiKeyPadMenu

@cchaos
Copy link
Contributor

cchaos commented Aug 1, 2022

Hi @sksamuel 👋 . The number of columns is purely based on the width CSS property applied to the wrapper. You can easily override this using one of the following techniques.

  1. Pass a custom className and apply your own CSS width property
  2. Pass an inline style block with your own value such as style={{ width: 400 }}
  3. If you're using Emotion for styles (EUI is transitioning to this), pass a custom css value such as
css={css`width: 400px;`}

@miukimiu
Copy link
Contributor

miukimiu commented Aug 1, 2022

When we start converting the EuiKeyPadMenu component to Emotion (#5685) we can consider adding a prop to make it easier for consumers to add more columns. Maybe a width prop on the wrapper component <EuiKeyPadMenu width={400} />?

Also if we add this ability to change the width we should add some guidelines on what max number of times per row is considered a good design practice.

@sksamuel
Copy link
Author

sksamuel commented Aug 1, 2022

@cchaos thanks that works :)

@daveyholler daveyholler added the answered Issues answered by the EUI team - auto-closes open issues in 7 days if no follow-up response label Dec 12, 2022
@github-actions
Copy link

👋 This issue hasn't seen activity in 3 days, so we're automatically closing this issue as answered. Please leave a comment if that's not the case, or if you have any remaining questions or issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered Issues answered by the EUI team - auto-closes open issues in 7 days if no follow-up response emotion
Projects
None yet
Development

No branches or pull requests

4 participants