Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Runtime performance baseline and monitoring #7499

Open
JasonStoltz opened this issue Feb 1, 2024 · 0 comments
Open

[Meta] Runtime performance baseline and monitoring #7499

JasonStoltz opened this issue Feb 1, 2024 · 0 comments

Comments

@JasonStoltz
Copy link
Member

JasonStoltz commented Feb 1, 2024

As our library continues to grow and evolve, we must evaluate and monitor how we're impacting performance in consuming projects -- particularly in Kibana.

This PR raised concerns about the potential performance impacts of the Emotion conversion.

We encountered some performance related issues in Kibana related to Emotion, but most of them have been mitigated by an effort to memoize emotion styles. At the time of writing this issue, we have about 80% of the library converted to Emotion, so we do not anticipate many more performance issues related to Emotion.

However, we must consider how we prevent future performance degredation and manage to a baseline level of performance in the EUI library on an ongoing basis.

The foundational task that we'd need to accomplish as part of this Meta issue is establishing that baseline, and putting a system in place to continually monitor it.

@JasonStoltz JasonStoltz changed the title [Meta] Emotion performance concerns [Meta] Performance concerns Feb 1, 2024
@JasonStoltz JasonStoltz changed the title [Meta] Performance concerns [Meta] Address Performance concerns Mar 28, 2024
@JasonStoltz JasonStoltz changed the title [Meta] Address Performance concerns [Meta] Performance concerns Mar 28, 2024
@JasonStoltz JasonStoltz changed the title [Meta] Performance concerns [Meta] Performance baseline and monitoring Apr 1, 2024
@JasonStoltz JasonStoltz changed the title [Meta] Performance baseline and monitoring [Meta] Run-time performance baseline and monitoring Apr 1, 2024
@JasonStoltz JasonStoltz changed the title [Meta] Run-time performance baseline and monitoring [Meta] Runtime performance baseline and monitoring Apr 1, 2024
@github-actions github-actions bot added the Stale label Oct 4, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2024
@cee-chen cee-chen removed the Stale label Oct 14, 2024
@cee-chen cee-chen reopened this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants