Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiInMemoryTable and EuiBasicTable should use ...rest to pass through props to Table #760

Closed
cjcenizal opened this issue May 2, 2018 · 1 comment · Fixed by #836
Closed
Assignees
Labels

Comments

@cjcenizal
Copy link
Contributor

This is a common pattern we use to support the application of HTML attributes to the rendered DOM. EuiTable supports this. We should make sure that consumers who are using this feature and migrate from EuiTable to EuiInMemoryTable or EuiBasicTable will be able to continue passing in whatever attributes they want.

CC @chandlerprall since you've been working with this code recently.

@cjcenizal cjcenizal added the bug label May 2, 2018
@cjcenizal cjcenizal changed the title EuiInMemoryTable andEuiBasicTable should use ...rest to pass through props to Table EuiInMemoryTable and EuiBasicTable should use ...rest to pass through props to Table May 2, 2018
@peteharverson
Copy link

Related to this, it seems that a className prop added to an EuiInMemoryTable isn't being passed down to the EuiBasicTable (and on to the table).

e.g. using

      <EuiInMemoryTable
        className="ml-anomalies-table"
        items={this.props.tableData.anomalies}
        columns={columns}
        pagination={{
          pageSizeOptions: [10, 25, 100]
        }}
        sorting={sorting}
        itemIdToExpandedRowMap={this.state.itemIdToExpandedRowMap}
      />

the applied ml-anomalies-table does not seem to get added:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants