Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tooltips in EuiContextMenuItem #808

Closed
timroes opened this issue May 9, 2018 · 0 comments
Closed

Allow tooltips in EuiContextMenuItem #808

timroes opened this issue May 9, 2018 · 0 comments

Comments

@timroes
Copy link
Contributor

timroes commented May 9, 2018

It would be nice if we would have a property to specify a tooltip for an EuiContextMenuItem. You unfortunately cannot build that with the current components, since the EuiTooltip element needs to wrap the actual trigger, meaning you would need to pass something like the following:

const items = [
  <EuiToolTip><EuiContextMenuItem/><EuiToolTip>,
  <EuiToolTip><EuiContextMenuItem/><EuiToolTip>
];
return <EuiContextMenu items={items}/>;

Unfortunately that breaks the styling of the panel and kills all keyboard controls, since the EuiContextMenu doesn't have the EuiContextMenuItem as direct children anymore.

Thus I would suggest to allow specifying a tooltip via property on EuiContextMenuItem. It would be super useful, since we then could possibly show explanation. My use-case would currently be to be able to show a help text, what "formatted CSV" and "raw CSV" is in the download popover in Inspector:

screenshot-20180509-103514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants