From 0fe630a4906db59348929b009e022910d6508f55 Mon Sep 17 00:00:00 2001 From: miukimiu Date: Thu, 9 Jul 2020 16:36:16 +0100 Subject: [PATCH 1/4] Add security analytics app icon --- CHANGELOG.md | 2 +- src/components/icon/assets/app_security_analytics.js | 6 ++++-- src/components/icon/assets/app_security_analytics.svg | 9 +++++---- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d94b270350e..a8e11a19b3b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ ## [`master`](https://github.com/elastic/eui/tree/master) -No public interface changes since `27.0.0`. +- Added `securityAnalyticsApp` app icon to `EuiIcon` ([#2755](https://github.com/elastic/eui/pull/2755)) ## [`27.0.0`](https://github.com/elastic/eui/tree/v27.0.0) - Added `paddingSize` prop to `EuiCard` ([#3638](https://github.com/elastic/eui/pull/3638)) diff --git a/src/components/icon/assets/app_security_analytics.js b/src/components/icon/assets/app_security_analytics.js index 5db2a0a588c..be923050557 100644 --- a/src/components/icon/assets/app_security_analytics.js +++ b/src/components/icon/assets/app_security_analytics.js @@ -4,16 +4,18 @@ const EuiIconAppSecurityAnalytics = ({ title, titleId, ...props }) => ( {title ? {title} : null} - + + ); diff --git a/src/components/icon/assets/app_security_analytics.svg b/src/components/icon/assets/app_security_analytics.svg index 948d029d3ff..774814f4221 100644 --- a/src/components/icon/assets/app_security_analytics.svg +++ b/src/components/icon/assets/app_security_analytics.svg @@ -1,4 +1,5 @@ - - - - + + + + + \ No newline at end of file From 56f5e0617936f86d2d9480e72b12d5d82c4b2d2b Mon Sep 17 00:00:00 2001 From: miukimiu Date: Thu, 9 Jul 2020 16:59:40 +0100 Subject: [PATCH 2/4] Tests and changelog --- CHANGELOG.md | 2 +- src/components/icon/__snapshots__/icon.test.tsx.snap | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a8e11a19b3b..1c1e1155821 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,6 @@ ## [`master`](https://github.com/elastic/eui/tree/master) -- Added `securityAnalyticsApp` app icon to `EuiIcon` ([#2755](https://github.com/elastic/eui/pull/2755)) +- Updated `securityAnalyticsApp` app icon ([#3720](https://github.com/elastic/eui/pull/3720)) ## [`27.0.0`](https://github.com/elastic/eui/tree/v27.0.0) - Added `paddingSize` prop to `EuiCard` ([#3638](https://github.com/elastic/eui/pull/3638)) diff --git a/src/components/icon/__snapshots__/icon.test.tsx.snap b/src/components/icon/__snapshots__/icon.test.tsx.snap index 4cfd06a76a9..75fd5336a77 100644 --- a/src/components/icon/__snapshots__/icon.test.tsx.snap +++ b/src/components/icon/__snapshots__/icon.test.tsx.snap @@ -6796,6 +6796,7 @@ exports[`EuiIcon props type securityAnalyticsApp is rendered 1`] = ` `; From 48fdb00ca92e235c04fd66ca1b5d9e226cc42490 Mon Sep 17 00:00:00 2001 From: miukimiu Date: Thu, 9 Jul 2020 17:02:51 +0100 Subject: [PATCH 3/4] Removing unecessary fill rule --- src/components/icon/assets/app_security_analytics.svg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/icon/assets/app_security_analytics.svg b/src/components/icon/assets/app_security_analytics.svg index 774814f4221..05d6f6674f9 100644 --- a/src/components/icon/assets/app_security_analytics.svg +++ b/src/components/icon/assets/app_security_analytics.svg @@ -1,5 +1,5 @@ - + \ No newline at end of file From 7634fa0fd887f8c37c96a66f1ffbca24d2401c7c Mon Sep 17 00:00:00 2001 From: miukimiu Date: Thu, 9 Jul 2020 18:53:55 +0100 Subject: [PATCH 4/4] removing fill none --- .../icon/__snapshots__/icon.test.tsx.snap | 95 +++++++------------ .../icon/assets/app_security_analytics.js | 1 - .../icon/assets/app_security_analytics.svg | 2 +- 3 files changed, 37 insertions(+), 61 deletions(-) diff --git a/src/components/icon/__snapshots__/icon.test.tsx.snap b/src/components/icon/__snapshots__/icon.test.tsx.snap index 75fd5336a77..b5aebaa52b6 100644 --- a/src/components/icon/__snapshots__/icon.test.tsx.snap +++ b/src/components/icon/__snapshots__/icon.test.tsx.snap @@ -6796,7 +6796,6 @@ exports[`EuiIcon props type securityAnalyticsApp is rendered 1`] = ` @@ -7697,16 +7696,14 @@ exports[`EuiIcon props type tokenCompletionSuggester is rendered 1`] = ` width="16" xmlns="http://www.w3.org/2000/svg" > - - - - + + `; @@ -7758,8 +7755,7 @@ exports[`EuiIcon props type tokenDenseVector is rendered 1`] = ` xmlns="http://www.w3.org/2000/svg" > `; @@ -7900,8 +7896,7 @@ exports[`EuiIcon props type tokenFlattened is rendered 1`] = ` xmlns="http://www.w3.org/2000/svg" > `; @@ -7954,7 +7949,7 @@ exports[`EuiIcon props type tokenHistogram is rendered 1`] = ` xmlns="http://www.w3.org/2000/svg" > `; @@ -8008,7 +8003,7 @@ exports[`EuiIcon props type tokenJoin is rendered 1`] = ` > @@ -8043,16 +8038,14 @@ exports[`EuiIcon props type tokenKeyword is rendered 1`] = ` width="16" xmlns="http://www.w3.org/2000/svg" > - - - - + + `; @@ -8254,7 +8247,7 @@ exports[`EuiIcon props type tokenPercolator is rendered 1`] = ` > @@ -8311,7 +8304,7 @@ exports[`EuiIcon props type tokenRankFeature is rendered 1`] = ` xmlns="http://www.w3.org/2000/svg" > `; @@ -8328,7 +8321,7 @@ exports[`EuiIcon props type tokenRankFeatures is rendered 1`] = ` xmlns="http://www.w3.org/2000/svg" > `; @@ -8362,19 +8355,14 @@ exports[`EuiIcon props type tokenSearchType is rendered 1`] = ` width="16" xmlns="http://www.w3.org/2000/svg" > - - - - - + + `; @@ -8460,7 +8448,7 @@ exports[`EuiIcon props type tokenText is rendered 1`] = ` xmlns="http://www.w3.org/2000/svg" > `; @@ -8476,20 +8464,9 @@ exports[`EuiIcon props type tokenTokenCount is rendered 1`] = ` width="16" xmlns="http://www.w3.org/2000/svg" > - - - - - - + `; diff --git a/src/components/icon/assets/app_security_analytics.js b/src/components/icon/assets/app_security_analytics.js index be923050557..799fedac5d2 100644 --- a/src/components/icon/assets/app_security_analytics.js +++ b/src/components/icon/assets/app_security_analytics.js @@ -4,7 +4,6 @@ const EuiIconAppSecurityAnalytics = ({ title, titleId, ...props }) => ( +