Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiMarkdownEditor] Fix styling for Amsterdam #4289

Merged
merged 7 commits into from
Nov 20, 2020

Conversation

miukimiu
Copy link
Contributor

@miukimiu miukimiu commented Nov 19, 2020

Summary

This PR fixes the amsterdam styles for the EuiMarkdownEditor:

  • Added border-radius similar to the EuiTextArea
  • Removed the default shadow and hover shadow when the textarea is focused
  • Removed the focus outline styles for the textarea because we have our default focus state (primary bottom border).

mdEditor-amst@2x

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@miukimiu miukimiu requested a review from cchaos November 19, 2020 18:53
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4289/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd honestly even consider removing the box-shadow from the default them on focus too because it's such a large component.

Also, for Amsterdam, do you want to round the corners of the bottom of the preview area too?

Screen Shot 2020-11-20 at 11 03 51 AM

src/themes/eui-amsterdam/overrides/_index.scss Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4289/

@miukimiu
Copy link
Contributor Author

Thanks, @cchaos. 🎉

I removed the box-shadow from the default theme and rounded the corners of the bottom of the preview area.

@miukimiu miukimiu merged commit d5f5d6f into elastic:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants