Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSuperDatePicker] Convert form control styles to Emotion #7904

Merged
merged 11 commits into from
Jul 23, 2024

Commits on Jul 22, 2024

  1. Initial Emotion setup

    - some shenanigans rquired because of existing render fn
    cee-chen committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    6cd8fce View commit details
    Browse the repository at this point in the history
  2. Convert date picker widths and width modifiers to Emotion

    + delete width Sass variables
    cee-chen committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    3c9a6c5 View commit details
    Browse the repository at this point in the history
  3. Fix/tweak various width permutations

    - `noUpdateButton` requires a few per-width-type tweaks to get this working as before in prod, due to changed CSS delcaration order
    
    - `isAutoRefreshOnly` is not correctly responding to width prop on prod, this fixes that
    cee-chen committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    e6c92d0 View commit details
    Browse the repository at this point in the history
  4. Convert remaining layout elements

    - flatten CSS where possible (in the case of `.euiFormControlLayout__childrenWrapper`'s border-radius it is sadly not possible)
    
    - un-DRY prettyFormat CSS for now, DRY out with popover buttons later
    
    - `!important` on `.euiSuperDatePicker__rangeInput` required to offset the CSS added by `fullWidth: true` on the form control layout
    cee-chen committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    2ea9e6f View commit details
    Browse the repository at this point in the history
  5. Convert needsUpdating state

    + simplify `.euiDatePopoverButton` to inherit from the form wrapper instead of reusing the static variable
    cee-chen committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    220a448 View commit details
    Browse the repository at this point in the history
  6. DRY out/convert euiSuperDatePickerText mixin + EuiDatePopoverButton

    - use flex for compressed height instead of static form variables
    
    - keep modifier classes for Kibana usage
    cee-chen committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    c4c4d49 View commit details
    Browse the repository at this point in the history
  7. Convert remaining form linear gradient/underline styles

    - [opinionated cleanup/change] set background colors on the layout wrapper div instead of the button where possible
    
    - reuse the CSS variable and form Emotion mixins where possible as well
    cee-chen committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    09c897e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    811ae87 View commit details
    Browse the repository at this point in the history
  9. changelog

    cee-chen committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    5bd947d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b61fe26 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. [tech debt] Convert Enzyme tests to RTL

    + fix test describe name
    cee-chen committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1583a79 View commit details
    Browse the repository at this point in the history