Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiSuperDatePicker] Convert quick select styles to Emotion #7909

Merged
merged 11 commits into from
Jul 29, 2024
Merged

[EuiSuperDatePicker] Convert quick select styles to Emotion #7909

merged 11 commits into from
Jul 29, 2024

Commits on Jul 25, 2024

  1. Remove unused refresh interval CSS 

    - not used anywhere in the EUI repo or Kibana
    @cee-chen
    cee-chen committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    12b03e3 View commit details
    Browse the repository at this point in the history

  2. Replace min-width button CSS with a prop instead 

    - much more straightforward and less custom CSS

+ replace className with a data-test-subj instead (used by several test selectors in Kibana)
    @cee-chen
    cee-chen committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1f87a27 View commit details
    Browse the repository at this point in the history

  3. Convert basic EuiQuickSelectPopover styles to Emotion 

    - other styles in this file are kind of all over the place and needs more refactoring
    @cee-chen
    cee-chen committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    c00dd28 View commit details
    Browse the repository at this point in the history

  4. Create new internal EuiQuickSelectPanel subcomponent 

    - contains all the required styling without requiring other usages to set classNames directly

- should also be flexible enough for both `div` and `fieldset/legend` usage
    @cee-chen
    cee-chen committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    025bb21 View commit details
    Browse the repository at this point in the history

  5. Refactor commonly used, recently used, and custom panels to use new s… 

    …ubcomponent

+ refactor recently used panel to use a flex column with gap instead of margins

+ reorder imports
    @cee-chen
    cee-chen committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    b9e4d46 View commit details
    Browse the repository at this point in the history

  6. Convert EuiRefreshInterval to use new subcomponent + fix missing i18n 

    + fix incorrect fieldset/legend usage - legend has to be the first child of fieldset to be usable. Plus the label isn't that helpful anyway, so let's create our own
    @cee-chen
    cee-chen committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    5ff0fd1 View commit details
    Browse the repository at this point in the history

  7. Update quick select panel to use new subcomponent 

    - fixes the label looking slightly different from the other panels

+ improve fieldset/legend workaround by absolutely positioning the arrows instead

- a11y tweaks - remove extra verbose screen reader only text, but add `aria-describedby` to make up for it

+ update remaining quick select tests from Enzyme to RTL
    @cee-chen
    cee-chen committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    26814bd View commit details
    Browse the repository at this point in the history

  8. Delete Sass files

    @cee-chen
    cee-chen committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    5c6a55e View commit details
    Browse the repository at this point in the history

  9. Update visual regression tests

    @cee-chen
    cee-chen committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    4f8dab2 View commit details
    Browse the repository at this point in the history

  10. changelog

    @cee-chen
    cee-chen committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    23661a1 View commit details
    Browse the repository at this point in the history

  11. Fix failing a11y test 

    - referencing a removed className - use data-test-subj instead
    @cee-chen
    cee-chen committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    25bf162 View commit details
    Browse the repository at this point in the history