-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Emotion] Convert EuiSelectableTemplateSitewide #7944
[Emotion] Convert EuiSelectableTemplateSitewide #7944
Commits on Aug 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ff9b383 - Browse repository at this point
Copy the full SHA ff9b383View commit details -
Convert
.euiSelectableTemplateSitewide__listItem
styles- this requires passing the styles obj to the `euiSelectableTemplateSitewideFormatOptions` function, which isn't actually a react component :| + remove unnecessary `!important` + fix import order/unnecessary extra dir
Configuration menu - View commit details
-
Copy full SHA for 3d7e847 - Browse repository at this point
Copy the full SHA 3d7e847View commit details -
[Sass only] Convert meta styles from Sass to Emotion
- Ignore `$euiSelectableTemplateFocusBackgroundLight/Dark` - we can't meaningfully use this background in our chroma.js calculations as chroma can't calculate contrast w/ alpha transparency. Using the default body background color should suffice / generates the same output colors
Configuration menu - View commit details
-
Copy full SHA for e5b64f8 - Browse repository at this point
Copy the full SHA e5b64f8View commit details -
[JS] Update the options utils to handle Emotion classNames
- again, these files aren't React components so we have to continuously pass the memoized style obj around, and use `RenderWithEuiStylesMemoizer` :T - [syntax] convert `renderOptionMeta` to obj arg notation for easier DX and fallbacks
Configuration menu - View commit details
-
Copy full SHA for b085bd2 - Browse repository at this point
Copy the full SHA b085bd2View commit details -
[tests] Update
euiSelectableTemplateSitewideRenderOptions
tests- render functions don't snapshot well, so we should just render the DOM + update the `searchValue` test to be marginally more useful/pointed
Configuration menu - View commit details
-
Copy full SHA for e1e06af - Browse repository at this point
Copy the full SHA e1e06afView commit details -
[docs] Fix src-docs demo that uses
className
s directly- not a lot we can for `__listItem`, but we can at least dogfood `euiSelectableTemplateSitewideRenderOptions` children
Configuration menu - View commit details
-
Copy full SHA for 93e8eca - Browse repository at this point
Copy the full SHA 93e8ecaView commit details -
[misc] Remove unnecessary type
as
cast/comment- doesn't appear to be needed anymore, not totally sure why tho
Configuration menu - View commit details
-
Copy full SHA for 26efbc8 - Browse repository at this point
Copy the full SHA 26efbc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 052708a - Browse repository at this point
Copy the full SHA 052708aView commit details -
[stories] Update VRT screenshots
+ add a vrt-only one to allow for snapshotting options
Configuration menu - View commit details
-
Copy full SHA for 86b867e - Browse repository at this point
Copy the full SHA 86b867eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3c779a - Browse repository at this point
Copy the full SHA e3c779aView commit details
Commits on Aug 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1ffb335 - Browse repository at this point
Copy the full SHA 1ffb335View commit details