Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emotion] Convert EuiSelectableTemplateSitewide #7944

Merged
merged 11 commits into from
Aug 6, 2024

Commits on Aug 5, 2024

  1. Configuration menu
    Copy the full SHA
    ff9b383 View commit details
    Browse the repository at this point in the history
  2. Convert .euiSelectableTemplateSitewide__listItem styles

    - this requires passing the styles obj to the `euiSelectableTemplateSitewideFormatOptions` function, which isn't actually a react component :|
    
    + remove unnecessary `!important`
    
    + fix import order/unnecessary extra dir
    cee-chen committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    3d7e847 View commit details
    Browse the repository at this point in the history
  3. [Sass only] Convert meta styles from Sass to Emotion

    - Ignore `$euiSelectableTemplateFocusBackgroundLight/Dark` - we can't meaningfully use this background in our chroma.js calculations as chroma can't calculate contrast w/ alpha transparency. Using the default body background color should suffice / generates the same output colors
    cee-chen committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    e5b64f8 View commit details
    Browse the repository at this point in the history
  4. [JS] Update the options utils to handle Emotion classNames

    - again, these files aren't React components so we have to continuously pass the memoized style obj around, and use `RenderWithEuiStylesMemoizer` :T
    
    - [syntax] convert `renderOptionMeta` to obj arg notation for easier DX and fallbacks
    cee-chen committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    b085bd2 View commit details
    Browse the repository at this point in the history
  5. [tests] Update euiSelectableTemplateSitewideRenderOptions tests

    - render functions don't snapshot well, so we should just render the DOM
    
    + update the `searchValue` test to be marginally more useful/pointed
    cee-chen committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    e1e06af View commit details
    Browse the repository at this point in the history
  6. [docs] Fix src-docs demo that uses classNames directly

    - not a lot we can for `__listItem`, but we can at least dogfood `euiSelectableTemplateSitewideRenderOptions` children
    cee-chen committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    93e8eca View commit details
    Browse the repository at this point in the history
  7. [misc] Remove unnecessary type as cast/comment

    - doesn't appear to be needed anymore, not totally sure why tho
    cee-chen committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    26efbc8 View commit details
    Browse the repository at this point in the history
  8. Delete Sass files

    cee-chen committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    052708a View commit details
    Browse the repository at this point in the history
  9. [stories] Update VRT screenshots

    + add a vrt-only one to allow for snapshotting options
    cee-chen committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    86b867e View commit details
    Browse the repository at this point in the history
  10. changelog

    cee-chen committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    e3c779a View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Configuration menu
    Copy the full SHA
    1ffb335 View commit details
    Browse the repository at this point in the history