-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Emotion] Convert EuiComboBox #7950
Commits on Aug 7, 2024
-
Convert base EuiComboBox styles
- class component with generic, so it's easier to use a render prop - we can avoid having to memoizing styles however by using `logicalStyle()` and `euiFormMaxWidth()` separate from combobox's styles + remove fullWidth modifier class
Configuration menu - View commit details
-
Copy full SHA for 036f334 - Browse repository at this point
Copy the full SHA 036f334View commit details -
Convert append/prepend margin styles to Emotion
- DRY it out to a prop and the internal `EuiComboBoxOptionAppendPrepend` util - remove applicable Sass
Configuration menu - View commit details
-
Copy full SHA for 5f334c6 - Browse repository at this point
Copy the full SHA 5f334c6View commit details -
Convert form control/input styles to Emotion
- requires render prop due to class component with generic :T + `removeOptionMessage` requires some extra typing now due to that - remove unnecessary icon className/CSS - now handled by EuiFormControlLayout + remove unnecessary `__inputWrap--fullWidth` - it's already full width by default, width is set by the combobox wrapper
Configuration menu - View commit details
-
Copy full SHA for bbdf2f4 - Browse repository at this point
Copy the full SHA bbdf2f4View commit details -
Convert input amsterdam overrides to Emotion
- use `inherit` property to handle both compressed and uncompressed styles - clean up form control styles into a nested obj - remove more modifiers from EuiCombBox (no Kibana usages)
Configuration menu - View commit details
-
Copy full SHA for 32144e9 - Browse repository at this point
Copy the full SHA 32144e9View commit details -
Convert pill styles to Emotion
+ convert margins to flex gap instead + move max-width CSS - no longer needs specificty override + convert EuiComboBoxPill from a class component to a function component
Configuration menu - View commit details
-
Copy full SHA for 4f3fccd - Browse repository at this point
Copy the full SHA 4f3fccdView commit details -
Convert options list styles to Emotion
- move JSX consts to inline JSX instead so we don't need multiple `RenderWithEuiStylesMemoizer` + DRY out new constant for `200` max height + import reorder
Configuration menu - View commit details
-
Copy full SHA for 8e84be5 - Browse repository at this point
Copy the full SHA 8e84be5View commit details -
🔥 Remove unused EuiComboBoxOption component/CSS
- EuiFilterSelectItem is being used instead - no top level export, so no deprecation/breaking change needed
Configuration menu - View commit details
-
Copy full SHA for 37b9d15 - Browse repository at this point
Copy the full SHA 37b9d15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bfac1b - Browse repository at this point
Copy the full SHA 5bfac1bView commit details -
(also lazily, since EuiSelectable has its own group labels)
Configuration menu - View commit details
-
Copy full SHA for 98490bc - Browse repository at this point
Copy the full SHA 98490bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8ceba2 - Browse repository at this point
Copy the full SHA b8ceba2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f0f3f3 - Browse repository at this point
Copy the full SHA 7f0f3f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 701d4d1 - Browse repository at this point
Copy the full SHA 701d4d1View commit details -
Fix plaintext prepend/append mobile wrapping
- tl;dr it shouldn't wrap
Configuration menu - View commit details
-
Copy full SHA for d8b173e - Browse repository at this point
Copy the full SHA d8b173eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0ed250 - Browse repository at this point
Copy the full SHA b0ed250View commit details
Commits on Aug 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2d0b7a0 - Browse repository at this point
Copy the full SHA 2d0b7a0View commit details -
+ move tooltip props to where it's being used in the story instead of a const
Configuration menu - View commit details
-
Copy full SHA for c6daf78 - Browse repository at this point
Copy the full SHA c6daf78View commit details