Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emotion] Convert EuiComboBox #7950

Merged
merged 16 commits into from
Aug 8, 2024
Merged

Commits on Aug 7, 2024

  1. Convert base EuiComboBox styles

    - class component with generic, so it's easier to use a render prop
    
    - we can avoid having to memoizing styles however by using `logicalStyle()` and `euiFormMaxWidth()` separate from combobox's styles
    
    + remove fullWidth modifier class
    cee-chen committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    036f334 View commit details
    Browse the repository at this point in the history
  2. Convert append/prepend margin styles to Emotion

    - DRY it out to a prop and the internal `EuiComboBoxOptionAppendPrepend` util
    
    - remove applicable Sass
    cee-chen committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5f334c6 View commit details
    Browse the repository at this point in the history
  3. Convert form control/input styles to Emotion

    - requires render prop due to class component with generic :T
    + `removeOptionMessage` requires some extra typing now due to that
    
    - remove unnecessary icon className/CSS - now handled by EuiFormControlLayout
    
    + remove unnecessary `__inputWrap--fullWidth` - it's already full width by default, width is set by the combobox wrapper
    cee-chen committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    bbdf2f4 View commit details
    Browse the repository at this point in the history
  4. Convert input amsterdam overrides to Emotion

    - use `inherit` property to handle both compressed and uncompressed styles
    - clean up form control styles into a nested obj
    
    - remove more modifiers from EuiCombBox (no Kibana usages)
    cee-chen committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    32144e9 View commit details
    Browse the repository at this point in the history
  5. Convert pill styles to Emotion

    + convert margins to flex gap instead
    
    + move max-width CSS - no longer needs specificty override
    
    + convert EuiComboBoxPill from a class component to a function component
    cee-chen committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    4f3fccd View commit details
    Browse the repository at this point in the history
  6. Convert options list styles to Emotion

    - move JSX consts to inline JSX instead so we don't need multiple `RenderWithEuiStylesMemoizer`
    
    + DRY out new constant for `200` max height
    
    + import reorder
    cee-chen committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    8e84be5 View commit details
    Browse the repository at this point in the history
  7. 🔥 Remove unused EuiComboBoxOption component/CSS

    - EuiFilterSelectItem is being used instead
    
    - no top level export, so no deprecation/breaking change needed
    cee-chen committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    37b9d15 View commit details
    Browse the repository at this point in the history
  8. Convert remaining option styles

    (lazily - see comment rationale)
    cee-chen committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5bfac1b View commit details
    Browse the repository at this point in the history
  9. Convert option title styles

    (also lazily, since EuiSelectable has its own group labels)
    cee-chen committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    98490bc View commit details
    Browse the repository at this point in the history
  10. Delete Sass files

    cee-chen committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    b8ceba2 View commit details
    Browse the repository at this point in the history
  11. VRT updates

    cee-chen committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    7f0f3f3 View commit details
    Browse the repository at this point in the history
  12. changelog

    cee-chen committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    701d4d1 View commit details
    Browse the repository at this point in the history
  13. Fix plaintext prepend/append mobile wrapping

    - tl;dr it shouldn't wrap
    cee-chen committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    d8b173e View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    b0ed250 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Update Cypress test

    cee-chen committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    2d0b7a0 View commit details
    Browse the repository at this point in the history
  2. Skip tooltip VRT

    + move tooltip props to where it's being used in the story instead of a const
    cee-chen committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    c6daf78 View commit details
    Browse the repository at this point in the history