Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSearchBar] Allow disabling selection auto sort in field_value_selection filters #7958

Merged
merged 11 commits into from
Aug 30, 2024

Commits on Aug 13, 2024

  1. Configuration menu
    Copy the full SHA
    cccb172 View commit details
    Browse the repository at this point in the history
  2. add changelog

    tgalfin committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    06eca37 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Configuration menu
    Copy the full SHA
    8f07fbc View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. [PR feedback] Minor test cleanup

    - move to a `describe` block with config key + move closer to `autoClose`
    - remove unnecessary `...requiredProps`, reuse `staticOptions` const
    - clean up assertions slightly
    cee-chen committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    e24b3c5 View commit details
    Browse the repository at this point in the history
  2. [PR feedback] Copy/docs pass

    - Tweak props table order
    - Minor wordsmithing
    cee-chen committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    74e712e View commit details
    Browse the repository at this point in the history
  3. Docs/Storybook examples

    + fix filters stories file name
    cee-chen committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    11e4b0e View commit details
    Browse the repository at this point in the history
  4. Simplify/clean up internal options state/naming

    - instead of `all/shown`, use `unsorted` and `sorted` to reflect new prop usage
    cee-chen committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    afe70fe View commit details
    Browse the repository at this point in the history
  5. [tech debt] Remove unused class methods

    - appears to have been used before EuiSearchBar dogfooded EuiSelectable
    cee-chen committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    72dece8 View commit details
    Browse the repository at this point in the history
  6. Various minor syntax/nit cleanups

    - store the count of activeItems instead of a full array, since we only care about the length
    
    - use getters and modern nullish syntax for configs with defaults
    cee-chen committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    96d5b68 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. [tech debt] Convert Promise syntax to modern async/await

    - remove separate async `resolveOptionsLoader` fn - for some reason this separate method causes the EuiSelectableList to remount completely, no idea why :T
    
    + add missing clearTimeout for scheduled cache wipe, which could potentially cause stale errors after unmount
    + add missing test case for `cache` config
    cee-chen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    0733b47 View commit details
    Browse the repository at this point in the history
  2. Restore UX where auto-sorted items should be scrolled to after being …

    …checked
    
    + retain selected/active index highlight (better UX than before, where focus/active index was lost)
    
    + simplify stateful test components and update autosort tests to be simpler and check for active attributes
    cee-chen committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c4972d2 View commit details
    Browse the repository at this point in the history