-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiSearchBar] Allow disabling selection auto sort in field_value_selection
filters
#7958
Commits on Aug 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cccb172 - Browse repository at this point
Copy the full SHA cccb172View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06eca37 - Browse repository at this point
Copy the full SHA 06eca37View commit details
Commits on Aug 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8f07fbc - Browse repository at this point
Copy the full SHA 8f07fbcView commit details
Commits on Aug 29, 2024
-
[PR feedback] Minor test cleanup
- move to a `describe` block with config key + move closer to `autoClose` - remove unnecessary `...requiredProps`, reuse `staticOptions` const - clean up assertions slightly
Configuration menu - View commit details
-
Copy full SHA for e24b3c5 - Browse repository at this point
Copy the full SHA e24b3c5View commit details -
- Tweak props table order - Minor wordsmithing
Configuration menu - View commit details
-
Copy full SHA for 74e712e - Browse repository at this point
Copy the full SHA 74e712eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11e4b0e - Browse repository at this point
Copy the full SHA 11e4b0eView commit details -
Simplify/clean up internal options state/naming
- instead of `all/shown`, use `unsorted` and `sorted` to reflect new prop usage
Configuration menu - View commit details
-
Copy full SHA for afe70fe - Browse repository at this point
Copy the full SHA afe70feView commit details -
[tech debt] Remove unused class methods
- appears to have been used before EuiSearchBar dogfooded EuiSelectable
Configuration menu - View commit details
-
Copy full SHA for 72dece8 - Browse repository at this point
Copy the full SHA 72dece8View commit details -
Various minor syntax/nit cleanups
- store the count of activeItems instead of a full array, since we only care about the length - use getters and modern nullish syntax for configs with defaults
Configuration menu - View commit details
-
Copy full SHA for 96d5b68 - Browse repository at this point
Copy the full SHA 96d5b68View commit details
Commits on Aug 30, 2024
-
[tech debt] Convert Promise syntax to modern async/await
- remove separate async `resolveOptionsLoader` fn - for some reason this separate method causes the EuiSelectableList to remount completely, no idea why :T + add missing clearTimeout for scheduled cache wipe, which could potentially cause stale errors after unmount + add missing test case for `cache` config
Configuration menu - View commit details
-
Copy full SHA for 0733b47 - Browse repository at this point
Copy the full SHA 0733b47View commit details -
Restore UX where auto-sorted items should be scrolled to after being …
…checked + retain selected/active index highlight (better UX than before, where focus/active index was lost) + simplify stateful test components and update autosort tests to be simpler and check for active attributes
Configuration menu - View commit details
-
Copy full SHA for c4972d2 - Browse repository at this point
Copy the full SHA c4972d2View commit details