Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion] Convert EuiFormLabel and EuiFormLegend #7967

Merged
merged 8 commits into from
Aug 15, 2024
Merged

[Emotion] Convert EuiFormLabel and EuiFormLegend #7967

merged 8 commits into from
Aug 15, 2024

Commits on Aug 15, 2024

  1. Convert @euiFormLabel mixin to an equivalent JS fn 

    - do something new/slightly clever with the returned title style obj
    @cee-chen
    cee-chen committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    2274458 View commit details
    Browse the repository at this point in the history

  2. Convert remaining EuiFormLabel styles 

    - reduce specificity of `[for]` CSS, which lets us remove an `!important` elsewhere, and remove need to set/override it at all for disabled labels
    @cee-chen
    cee-chen committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    001c59c View commit details
    Browse the repository at this point in the history

  3. Convert remaining EuiFormLegend styles

    @cee-chen
    cee-chen committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    386fc74 View commit details
    Browse the repository at this point in the history

  4. Delete Sass files

    @cee-chen
    cee-chen committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    322e041 View commit details
    Browse the repository at this point in the history

  5. Update downstream snapshots 

    - remove mounted Emotion snapshots from EuiFormRow in favor of specific assertion
    @cee-chen
    cee-chen committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    080f831 View commit details
    Browse the repository at this point in the history

  6. Update VRT screenshots

    @cee-chen
    cee-chen committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    9829dde View commit details
    Browse the repository at this point in the history

  7. Update downstream VRT screenshots 

    - likely just minor typographic changes, but might as well update these while we're here
    @cee-chen
    cee-chen committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    c65d56b View commit details
    Browse the repository at this point in the history

  8. changelog

    @cee-chen
    cee-chen committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    dc2ede9 View commit details
    Browse the repository at this point in the history