diff --git a/CHANGELOG.md b/CHANGELOG.md index 5156fd31ab9..c9d7a103532 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ ## [`master`](https://github.com/elastic/eui/tree/master) +**Bug fixes** +- `EuiInMemoryTable` and `EuiBasicTable` now pass unknown props through to their child ([#836](https://github.com/elastic/eui/pull/836)) + **Breaking changes** - Move `EuiBasicTable`'s `itemId` prop from `selection` to a top-level property ([#830](https://github.com/elastic/eui/pull/830)) diff --git a/src/components/basic_table/__snapshots__/basic_table.test.js.snap b/src/components/basic_table/__snapshots__/basic_table.test.js.snap index 0d88aa84b94..f9370dfb08b 100644 --- a/src/components/basic_table/__snapshots__/basic_table.test.js.snap +++ b/src/components/basic_table/__snapshots__/basic_table.test.js.snap @@ -2,7 +2,9 @@ exports[`EuiBasicTable basic - empty - custom message 1`] = `
@@ -37,7 +39,9 @@ exports[`EuiBasicTable basic - empty - custom message 1`] = ` exports[`EuiBasicTable basic - empty - custom message as node 1`] = `
@@ -80,7 +84,9 @@ exports[`EuiBasicTable basic - empty - custom message as node 1`] = ` exports[`EuiBasicTable basic - empty 1`] = `
@@ -115,7 +121,9 @@ exports[`EuiBasicTable basic - empty 1`] = ` exports[`EuiBasicTable basic - with items 1`] = `
@@ -276,7 +284,9 @@ exports[`EuiBasicTable itemIdToExpandedRowMap renders an expanded row 1`] = ` exports[`EuiBasicTable with pagination - 2nd page 1`] = `
@@ -344,7 +354,9 @@ exports[`EuiBasicTable with pagination - 2nd page 1`] = ` exports[`EuiBasicTable with pagination 1`] = `
@@ -428,7 +440,9 @@ exports[`EuiBasicTable with pagination 1`] = ` exports[`EuiBasicTable with pagination and error 1`] = `
@@ -469,7 +483,9 @@ exports[`EuiBasicTable with pagination and error 1`] = ` exports[`EuiBasicTable with pagination and selection 1`] = `
@@ -611,7 +627,9 @@ exports[`EuiBasicTable with pagination and selection 1`] = ` exports[`EuiBasicTable with pagination, selection and sorting 1`] = `
@@ -770,7 +788,9 @@ exports[`EuiBasicTable with pagination, selection and sorting 1`] = ` exports[`EuiBasicTable with pagination, selection, sorting and a single record action 1`] = `
@@ -1020,7 +1040,9 @@ exports[`EuiBasicTable with pagination, selection, sorting and a single record a exports[`EuiBasicTable with pagination, selection, sorting and column dataType 1`] = `
@@ -1179,7 +1201,9 @@ exports[`EuiBasicTable with pagination, selection, sorting and column dataType 1 exports[`EuiBasicTable with pagination, selection, sorting and column renderer 1`] = `
@@ -1338,7 +1362,9 @@ exports[`EuiBasicTable with pagination, selection, sorting and column renderer 1 exports[`EuiBasicTable with pagination, selection, sorting and multiple record actions 1`] = `
@@ -1582,7 +1608,9 @@ exports[`EuiBasicTable with pagination, selection, sorting and multiple record a exports[`EuiBasicTable with pagination, selection, sorting, column renderer and column dataType 1`] = `
@@ -1741,7 +1769,9 @@ exports[`EuiBasicTable with pagination, selection, sorting, column renderer and exports[`EuiBasicTable with sortable columns and sorting disabled 1`] = `
@@ -1814,7 +1844,9 @@ exports[`EuiBasicTable with sortable columns and sorting disabled 1`] = ` exports[`EuiBasicTable with sorting 1`] = `
diff --git a/src/components/basic_table/__snapshots__/in_memory_table.test.js.snap b/src/components/basic_table/__snapshots__/in_memory_table.test.js.snap index 5a5e03bfbe2..7480af254a8 100644 --- a/src/components/basic_table/__snapshots__/in_memory_table.test.js.snap +++ b/src/components/basic_table/__snapshots__/in_memory_table.test.js.snap @@ -2,6 +2,8 @@ exports[`EuiInMemoryTable empty array 1`] = ` +
{table} {paginationBar}
diff --git a/src/components/basic_table/in_memory_table.js b/src/components/basic_table/in_memory_table.js index ba851cac69d..d4a18aebf9a 100644 --- a/src/components/basic_table/in_memory_table.js +++ b/src/components/basic_table/in_memory_table.js @@ -263,6 +263,7 @@ export class EuiInMemoryTable extends Component { sorting: hasSorting, itemIdToExpandedRowMap, itemId, + ...rest } = this.props; const { @@ -311,6 +312,7 @@ export class EuiInMemoryTable extends Component { noItemsMessage={message} compressed={compressed} itemIdToExpandedRowMap={itemIdToExpandedRowMap} + {...rest} /> );