Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error.message mapping for system.syslog #9304

Closed
wants to merge 2 commits into from

Conversation

weslambert
Copy link

@weslambert weslambert commented Mar 7, 2024

  • Bug

The error.message mapping did not exist for system.syslog

Added error.message mapping to ecs.yml for system.syslog

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@weslambert weslambert requested a review from a team as a code owner March 7, 2024 15:48
@weslambert weslambert requested review from a team as code owners March 7, 2024 15:51
Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ali786XI
Copy link
Contributor

/test

1 similar comment
@kush-elastic
Copy link
Collaborator

/test

@elasticmachine
Copy link

elasticmachine commented Mar 11, 2024

💔 Build Failed

Failed CI Steps

History

@kush-elastic
Copy link
Collaborator

kush-elastic commented Mar 11, 2024

@weslambert
I think you have not run elastic-package build before pushing the code.
Can you run the build and push code again?

@ishleenk17
Copy link
Contributor

@weslambert : The README is not updated. Please run elastic-package build and commit the README file as well

@botelastic
Copy link

botelastic bot commented Apr 10, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Apr 10, 2024
@botelastic
Copy link

botelastic bot commented May 10, 2024

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants