From 01b52fe5b0c948e468e26cb7dcb992f7ea0f3967 Mon Sep 17 00:00:00 2001
From: Maxim Palenov <maxim.palenov@elastic.co>
Date: Fri, 27 Jan 2023 12:30:21 +0100
Subject: [PATCH] rollback StatusChangeArgsWithMessage to StatusChangeArgs

---
 .../client_for_executors/client_interface.ts          | 11 +++++------
 .../rule_preview/api/preview_rules/route.ts           |  4 ++--
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/x-pack/plugins/security_solution/server/lib/detection_engine/rule_monitoring/logic/rule_execution_log/client_for_executors/client_interface.ts b/x-pack/plugins/security_solution/server/lib/detection_engine/rule_monitoring/logic/rule_execution_log/client_for_executors/client_interface.ts
index 54d9055f1874d4..cb65b42d50b69d 100644
--- a/x-pack/plugins/security_solution/server/lib/detection_engine/rule_monitoring/logic/rule_execution_log/client_for_executors/client_interface.ts
+++ b/x-pack/plugins/security_solution/server/lib/detection_engine/rule_monitoring/logic/rule_execution_log/client_for_executors/client_interface.ts
@@ -107,15 +107,14 @@ export interface RunningStatusChangeArgs {
   newStatus: RuleExecutionStatus.running;
 }
 
-export interface StatusChangeArgsWithMessage {
-  newStatus: Exclude<RuleExecutionStatus, RuleExecutionStatus.running>;
-  metrics?: MetricsArgs;
-  message: string;
-}
 /**
  * Information about the status change event.
  */
-export type StatusChangeArgs = RunningStatusChangeArgs | StatusChangeArgsWithMessage;
+export interface StatusChangeArgs {
+  newStatus: RuleExecutionStatus;
+  message?: string;
+  metrics?: MetricsArgs;
+}
 
 export interface MetricsArgs {
   searchDurations?: string[];
diff --git a/x-pack/plugins/security_solution/server/lib/detection_engine/rule_preview/api/preview_rules/route.ts b/x-pack/plugins/security_solution/server/lib/detection_engine/rule_preview/api/preview_rules/route.ts
index ce91f9cd1ee796..457412dd015016 100644
--- a/x-pack/plugins/security_solution/server/lib/detection_engine/rule_preview/api/preview_rules/route.ts
+++ b/x-pack/plugins/security_solution/server/lib/detection_engine/rule_preview/api/preview_rules/route.ts
@@ -39,7 +39,7 @@ import { throwAuthzError } from '../../../../machine_learning/validation';
 import { buildRouteValidation } from '../../../../../utils/build_validation/route_validation';
 import type { SecuritySolutionPluginRouter } from '../../../../../types';
 
-import type { RuleExecutionContext, StatusChangeArgsWithMessage } from '../../../rule_monitoring';
+import type { RuleExecutionContext, StatusChangeArgs } from '../../../rule_monitoring';
 
 import type { ConfigType } from '../../../../../config';
 import { alertInstanceFactoryStub } from '../../../signals/preview/alert_instance_factory_stub';
@@ -123,7 +123,7 @@ export const previewRulesRoute = async (
         const spaceId = siemClient.getSpaceId();
         const previewId = uuidv4();
         const username = security?.authc.getCurrentUser(request)?.username;
-        const loggedStatusChanges: Array<RuleExecutionContext & StatusChangeArgsWithMessage> = [];
+        const loggedStatusChanges: Array<RuleExecutionContext & StatusChangeArgs> = [];
         const previewRuleExecutionLogger = createPreviewRuleExecutionLogger(loggedStatusChanges);
         const runState: Record<string, unknown> = {};
         const logs: RulePreviewLogs[] = [];