From 41571772ce924cf0b960d0458ceb74e69d060d11 Mon Sep 17 00:00:00 2001 From: Melissa Alvarez Date: Wed, 5 Aug 2020 09:49:19 -0400 Subject: [PATCH] update edit test wording for clarity --- .../apps/ml/data_frame_analytics/classification_creation.ts | 2 +- .../ml/data_frame_analytics/outlier_detection_creation.ts | 2 +- .../apps/ml/data_frame_analytics/regression_creation.ts | 2 +- .../functional/services/ml/data_frame_analytics_edit.ts | 4 +--- x-pack/test/functional/services/ml/index.ts | 6 +----- 5 files changed, 5 insertions(+), 11 deletions(-) diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation.ts index 4f5780562ae49a..a62bfdcde0572a 100644 --- a/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation.ts +++ b/x-pack/test/functional/apps/ml/data_frame_analytics/classification_creation.ts @@ -198,7 +198,7 @@ export default function ({ getService }: FtrProviderContext) { await ml.dataFrameAnalyticsEdit.updateAnalyticsJob(); }); - it('displays details for the created job in the analytics table', async () => { + it('displays details for the edited job in the analytics table', async () => { await ml.dataFrameAnalyticsTable.assertAnalyticsRowFields(testData.jobId, { id: testData.jobId, description: editedDescription, diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation.ts index ca1873ab4e1c6c..5b89cec49db3e4 100644 --- a/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation.ts +++ b/x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation.ts @@ -216,7 +216,7 @@ export default function ({ getService }: FtrProviderContext) { await ml.dataFrameAnalyticsEdit.updateAnalyticsJob(); }); - it('displays details for the created job in the analytics table', async () => { + it('displays details for the edited job in the analytics table', async () => { await ml.dataFrameAnalyticsTable.assertAnalyticsRowFields(testData.jobId, { id: testData.jobId, description: editedDescription, diff --git a/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation.ts b/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation.ts index 27284812c38e3b..a67a3483233479 100644 --- a/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation.ts +++ b/x-pack/test/functional/apps/ml/data_frame_analytics/regression_creation.ts @@ -198,7 +198,7 @@ export default function ({ getService }: FtrProviderContext) { await ml.dataFrameAnalyticsEdit.updateAnalyticsJob(); }); - it('displays details for the created job in the analytics table', async () => { + it('displays details for the edited job in the analytics table', async () => { await ml.dataFrameAnalyticsTable.assertAnalyticsRowFields(testData.jobId, { id: testData.jobId, description: editedDescription, diff --git a/x-pack/test/functional/services/ml/data_frame_analytics_edit.ts b/x-pack/test/functional/services/ml/data_frame_analytics_edit.ts index ea803415f77aeb..173e6a78ed93de 100644 --- a/x-pack/test/functional/services/ml/data_frame_analytics_edit.ts +++ b/x-pack/test/functional/services/ml/data_frame_analytics_edit.ts @@ -7,12 +7,10 @@ import expect from '@kbn/expect'; import { FtrProviderContext } from '../../ftr_provider_context'; import { MlCommon } from './common'; -import { MlApi } from './api'; export function MachineLearningDataFrameAnalyticsEditProvider( { getService }: FtrProviderContext, - mlCommon: MlCommon, - mlApi: MlApi + mlCommon: MlCommon ) { const testSubjects = getService('testSubjects'); diff --git a/x-pack/test/functional/services/ml/index.ts b/x-pack/test/functional/services/ml/index.ts index f112109c1b9130..fd36bb0f47f95d 100644 --- a/x-pack/test/functional/services/ml/index.ts +++ b/x-pack/test/functional/services/ml/index.ts @@ -48,11 +48,7 @@ export function MachineLearningProvider(context: FtrProviderContext) { common, api ); - const dataFrameAnalyticsEdit = MachineLearningDataFrameAnalyticsEditProvider( - context, - common, - api - ); + const dataFrameAnalyticsEdit = MachineLearningDataFrameAnalyticsEditProvider(context, common); const dataFrameAnalyticsTable = MachineLearningDataFrameAnalyticsTableProvider(context); const dataVisualizer = MachineLearningDataVisualizerProvider(context); const dataVisualizerFileBased = MachineLearningDataVisualizerFileBasedProvider(context, common);