From 7cbc4746e7db4d4a62c73a3d0563eb918107d0f1 Mon Sep 17 00:00:00 2001 From: Spencer Alger Date: Fri, 9 Jan 2015 12:28:08 -0700 Subject: [PATCH] [aggConfigs] harden #getResponseAggById() --- src/kibana/components/vis/_agg_configs.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/kibana/components/vis/_agg_configs.js b/src/kibana/components/vis/_agg_configs.js index a1069849a24c0f..51c4ae9e08b006 100644 --- a/src/kibana/components/vis/_agg_configs.js +++ b/src/kibana/components/vis/_agg_configs.js @@ -133,9 +133,11 @@ define(function (require) { * @return {AggConfig} */ AggConfigs.prototype.getResponseAggById = function (id) { + id = String(id); var reqAgg = _.find(this.getRequestAggs(), function (agg) { - return id.substr(0, agg.id.length) === agg.id; + return id.substr(0, String(agg.id).length) === agg.id; }); + if (!reqAgg) return; return _.find(reqAgg.getResponseAggs(), { id: id }); };