From 8d7aae0c214c9ed8f7e5daa98a7f24f9f131cfa3 Mon Sep 17 00:00:00 2001 From: spalger Date: Mon, 21 Sep 2020 16:55:08 -0700 Subject: [PATCH] Revert "Accessibility dashboard edit panel tests (#77829)" This reverts commit e15b4c43d4b570822ba31801931069b1bbb87217. --- test/accessibility/apps/dashboard_panel.ts | 2 +- .../apps/dashboard_edit_panel.ts | 118 ------------------ x-pack/test/accessibility/config.ts | 1 - 3 files changed, 1 insertion(+), 120 deletions(-) delete mode 100644 x-pack/test/accessibility/apps/dashboard_edit_panel.ts diff --git a/test/accessibility/apps/dashboard_panel.ts b/test/accessibility/apps/dashboard_panel.ts index 1a817ce6b7a1c5..03fa76387da1f9 100644 --- a/test/accessibility/apps/dashboard_panel.ts +++ b/test/accessibility/apps/dashboard_panel.ts @@ -18,6 +18,7 @@ */ import { FtrProviderContext } from '../ftr_provider_context'; + export default function ({ getService, getPageObjects }: FtrProviderContext) { const PageObjects = getPageObjects(['common', 'dashboard', 'header', 'home', 'settings']); const a11y = getService('a11y'); @@ -30,7 +31,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', { useActualUrl: true, }); - await PageObjects.home.addSampleDataSet('flights'); await PageObjects.common.navigateToApp('dashboard'); await testSubjects.click('dashboardListingTitleLink-[Flights]-Global-Flight-Dashboard'); diff --git a/x-pack/test/accessibility/apps/dashboard_edit_panel.ts b/x-pack/test/accessibility/apps/dashboard_edit_panel.ts deleted file mode 100644 index 9c0827e4128cfd..00000000000000 --- a/x-pack/test/accessibility/apps/dashboard_edit_panel.ts +++ /dev/null @@ -1,118 +0,0 @@ -/* - * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one - * or more contributor license agreements. Licensed under the Elastic License; - * you may not use this file except in compliance with the Elastic License. - */ - -import { FtrProviderContext } from '../ftr_provider_context'; - -export default function ({ getService, getPageObjects }: FtrProviderContext) { - const { dashboard } = getPageObjects(['dashboard']); - const a11y = getService('a11y'); - const dashboardPanelActions = getService('dashboardPanelActions'); - const testSubjects = getService('testSubjects'); - const esArchiver = getService('esArchiver'); - const drilldowns = getService('dashboardDrilldownsManage'); - const kibanaServer = getService('kibanaServer'); - const PageObjects = getPageObjects(['security', 'common']); - const toasts = getService('toasts'); - - describe('Dashboard Edit Panel', () => { - before(async () => { - await esArchiver.load('dashboard/drilldowns'); - await esArchiver.loadIfNeeded('logstash_functional'); - await kibanaServer.uiSettings.replace({ defaultIndex: 'logstash-*' }); - await PageObjects.common.navigateToApp('dashboard'); - await dashboard.loadSavedDashboard(drilldowns.DASHBOARD_WITH_PIE_CHART_NAME); - await testSubjects.click('dashboardEditMode'); - }); - - after(async () => { - await esArchiver.unload('dashboard/drilldowns'); - }); - - // embeddable edit panel - it(' A11y test on dashboard edit panel menu options', async () => { - await testSubjects.click('embeddablePanelToggleMenuIcon'); - await a11y.testAppSnapshot(); - }); - - // clone panel - it(' A11y test on dashboard embeddable clone panel', async () => { - await testSubjects.click('embeddablePanelAction-clonePanel'); - await a11y.testAppSnapshot(); - await toasts.dismissAllToasts(); - await dashboardPanelActions.removePanelByTitle('Visualization PieChart (copy)'); - }); - - // edit dashboard title - it(' A11y test on dashboard embeddable edit dashboard title', async () => { - await testSubjects.click('embeddablePanelToggleMenuIcon'); - await testSubjects.click('embeddablePanelAction-ACTION_CUSTOMIZE_PANEL'); - await a11y.testAppSnapshot(); - await testSubjects.click('customizePanelHideTitle'); - await a11y.testAppSnapshot(); - await testSubjects.click('saveNewTitleButton'); - }); - - // https://github.com/elastic/kibana/issues/77931 - it.skip('A11y test for edit visualization and save', async () => { - await testSubjects.click('embeddablePanelToggleMenuIcon'); - await testSubjects.click('embeddablePanelAction-editPanel'); - await testSubjects.click('visualizesaveAndReturnButton'); - await a11y.testAppSnapshot(); - }); - - // https://github.com/elastic/kibana/issues/77422 - it.skip('A11y test on dashboard embeddable custom time range', async () => { - await testSubjects.click('embeddablePanelToggleMenuIcon'); - await testSubjects.click('embeddablePanelAction-CUSTOM_TIME_RANGE'); - await a11y.testAppSnapshot(); - }); - - // inspector panel - it('A11y test on dashboard embeddable open inspector', async () => { - await testSubjects.click('embeddablePanelToggleMenuIcon'); - await testSubjects.click('embeddablePanelAction-openInspector'); - await a11y.testAppSnapshot(); - await testSubjects.click('euiFlyoutCloseButton'); - }); - - // create drilldown - it('A11y test on dashboard embeddable open flyout and drilldown', async () => { - await testSubjects.click('embeddablePanelToggleMenuIcon'); - await testSubjects.click('embeddablePanelAction-OPEN_FLYOUT_ADD_DRILLDOWN'); - await a11y.testAppSnapshot(); - await testSubjects.click('flyoutCloseButton'); - }); - - // fullscreen - it('A11y test on dashboard embeddable fullscreen', async () => { - await testSubjects.click('embeddablePanelToggleMenuIcon'); - await testSubjects.click('embeddablePanelAction-togglePanel'); - await a11y.testAppSnapshot(); - }); - - // minimize fullscreen panel - it('A11y test on dashboard embeddable fullscreen minimize ', async () => { - await testSubjects.click('embeddablePanelToggleMenuIcon'); - await testSubjects.click('embeddablePanelAction-togglePanel'); - await a11y.testAppSnapshot(); - }); - - // replace panel - it('A11y test on dashboard embeddable replace panel', async () => { - await testSubjects.click('embeddablePanelToggleMenuIcon'); - await testSubjects.click('embeddablePanelAction-replacePanel'); - await a11y.testAppSnapshot(); - await testSubjects.click('euiFlyoutCloseButton'); - }); - - // delete from dashboard - it('A11y test on dashboard embeddable delete panel', async () => { - await testSubjects.click('embeddablePanelToggleMenuIcon'); - await testSubjects.click('embeddablePanelAction-deletePanel'); - await a11y.testAppSnapshot(); - }); - }); -} diff --git a/x-pack/test/accessibility/config.ts b/x-pack/test/accessibility/config.ts index 9382a7186db542..bae7b688fd28cc 100644 --- a/x-pack/test/accessibility/config.ts +++ b/x-pack/test/accessibility/config.ts @@ -21,7 +21,6 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) { require.resolve('./apps/search_profiler'), require.resolve('./apps/uptime'), require.resolve('./apps/spaces'), - require.resolve('./apps/dashboard_edit_panel'), ], pageObjects, services,