Skip to content

Commit

Permalink
refactor(discover): add popover close button
Browse files Browse the repository at this point in the history
  • Loading branch information
Marco Antonio Ghiani committed Sep 25, 2024
1 parent a2cd794 commit a3ac8fe
Showing 1 changed file with 25 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,14 @@ import {
DataGridDensity,
} from '@kbn/unified-data-table';
import React from 'react';
import { EuiCodeBlock, EuiFlexGroup, EuiFlexItem, EuiText, EuiTitle } from '@elastic/eui';
import {
EuiButtonIcon,
EuiCodeBlock,
EuiFlexGroup,
EuiFlexItem,
EuiText,
EuiTitle,
} from '@elastic/eui';
import {
ShouldShowFieldInTableHandler,
getLogDocumentOverview,
Expand All @@ -23,7 +30,12 @@ import { JsonCodeEditor } from '@kbn/unified-doc-viewer-plugin/public';
import { DocViewFilterFn } from '@kbn/unified-doc-viewer/types';
import { Resource } from './resource';
import { Content } from './content';
import { contentLabel, jsonLabel, resourceLabel } from '../translations';
import {
closeCellActionPopoverText,
contentLabel,
jsonLabel,
resourceLabel,
} from '../translations';
import { createResourceFields, formatJsonDocumentForContent } from './utils';

export interface SummaryColumnFactoryDeps {
Expand Down Expand Up @@ -94,7 +106,7 @@ const SummaryCell = ({
};

const SummaryCellPopover = (props: SummaryColumnProps & SummaryColumnFactoryDeps) => {
const { row, dataView, fieldFormats, onFilter } = props;
const { row, dataView, fieldFormats, onFilter, closePopover } = props;

const resourceFields = createResourceFields(row);
const shouldRenderResource = resourceFields.length > 0;
Expand All @@ -106,7 +118,16 @@ const SummaryCellPopover = (props: SummaryColumnProps & SummaryColumnFactoryDeps
const shouldRenderSource = !shouldRenderContent;

return (
<EuiFlexGroup direction="column" css={{ width: 580 }}>
<EuiFlexGroup direction="column" css={{ position: 'relative', width: 580 }}>
<EuiButtonIcon
aria-label={closeCellActionPopoverText}
data-test-subj="docTableClosePopover"
iconSize="s"
iconType="cross"
size="xs"
onClick={closePopover}
css={{ position: 'absolute', right: 0 }}
/>
{shouldRenderResource && (
<EuiFlexGroup direction="column" gutterSize="s">
<EuiTitle size="xxs">
Expand Down

0 comments on commit a3ac8fe

Please sign in to comment.