Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring APM modes #102704

Closed
mshustov opened this issue Jun 21, 2021 · 4 comments · Fixed by #112973
Closed

Support configuring APM modes #102704

mshustov opened this issue Jun 21, 2021 · 4 comments · Fixed by #112973
Assignees
Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

mshustov commented Jun 21, 2021

With #102624 Kibana will be able to implement three different modes:

mode kibana.yml finalized agent config
APM agent sends data to the APM server, Kibana relies on the agent to implement log correlation. active: true { active: true, disableSend: false }
APM agent doesn't send data to the APM server, but Kibana uses it to implement log correlation. active: undefined { active: true, disableSend: true }
APM agent is disabled completely. active: false { active: false, disableSend: true }

Kibana should provide sensible APM agent defaults for every mode.
A Kibana user should be able to switch between modes.
New Kibana default shouldn't lead to a performance regression (verify with load testing).

blocked by #102624

@mshustov mshustov added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jun 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo
Copy link
Member

afharo commented Aug 16, 2021

should we consider a 4th option? [1] but sending to an Elastic-owned server (if users want to help us with performance metrics). What do you think?

@mshustov
Copy link
Contributor Author

but sending to an Elastic-owned server

It's [1] supplied with a special URL. The URL should be provided via the config file or an env var, not hardcoded in the Kibana sources. So I don't believe it requires an additional mode.

@trentm
Copy link
Member

trentm commented Nov 9, 2021

[email protected] is now published with the contextPropagationOnly config var.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants