Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Styling of "Document" when image field formatter is used #106852

Closed
timroes opened this issue Jul 27, 2021 · 1 comment · Fixed by #111987
Closed

[Discover] Styling of "Document" when image field formatter is used #106852

timroes opened this issue Jul 27, 2021 · 1 comment · Fixed by #111987
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@timroes
Copy link
Contributor

timroes commented Jul 27, 2021

When having a field configured using the image field formatter (URL > img), the way the summarized "Document" view is shown feels a bit off:

screenshot-20210727-153436

Because currently the text is aligning to the bottom of the image it actually can "push" the text out of the clipped height leaving that above weird view.

It's more obvious what happens when using a higher truncation size:

screenshot-20210727-153907

I don't think this is the ideal presentation when using images, so we should check if we can optimize that. I am not sure if simply aligning to the top is better, since it might cause weird effects with different height texts, so we might need to play around a bit.

This view leads to a couple of more problems when used in data grid, since datagrid doesn't hide overflows (see elastic/eui#4959), leading to a slightly weirder UX, e.g. when selecting cells:

screenshot-20210727-145031

@timroes timroes added Feature:Discover Discover Application enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jul 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes added bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed enhancement New value added to drive a business result impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Aug 18, 2021
@timroes timroes added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@timroes timroes self-assigned this Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants